security/pfSense-pkg-acme: update formatting and descriptions #1248
Conversation
| <include_file>/usr/local/pkg/acme/acme.inc</include_file> | ||
| <menu> | ||
| <name>Acme Certificates</name> | ||
| <name>ACME Certificates</name> |
There was a problem hiding this comment.
Changing the menu name is fairly disruptive. Even just changing the case, it won't match in the code that adds/removes menu entries and some users will end up with two menu entries depending on what they do.
|
|
||
| $section->addInput(new \Form_Input( | ||
| 'email', | ||
| 'E-Mail Address', | ||
| 'text', | ||
| $pconfig['email'] | ||
| ))->setHelp('The e-mail address to register for this key. This is used by Let\'s Encrypt to send automated certificate expiration notices.'); | ||
| ))->setHelp('The e-mail address to register for this key. This is used to send automated certificate expiration notices.'); |
There was a problem hiding this comment.
This should at least retain a reference to it being the CA that sends these not the firewall. It's easy for users to be confused otherwise.
e.g. "The ACME Server/CA may send messages to this address, such as automated notices for expiring certificates."
|
To effectively track changes and bug/feature requests, we require an entry on the pfSense Redmine issue tracker associated with every pull request, and likewise the Redmine entry should also have a link back to the pull request. Please associate this PR to a Redmine issue either by locating an existing issue at https://redmine.pfsense.org or by creating a new issue. Add a link to the Redmine issue that points to this PR, and also add a link on the PR to the Redmine issue. For more information, see https://docs.netgate.com/pfsense/en/latest/development/pull-request.html |
marcos-ng
changed the title
Formatting updates for ACME