Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security/pfSense-pkg-acme: update formatting and descriptions #1248

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

security/pfSense-pkg-acme: update formatting and descriptions #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
900bbec
security/pfSense-pkg-acme: update code formatting and typos
heitbaum Mar 25, 2023
df5e15e
security/pfSense-pkg-acme: fix indentation acme.inc
heitbaum Mar 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions security/pfSense-pkg-acme/files/usr/local/pkg/acme.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@
]]>
</copyright>
<name>acme</name>
<title>Acme</title>
<title>ACME</title>
<include_file>/usr/local/pkg/acme/acme.inc</include_file>
<menu>
<name>Acme Certificates</name>
<name>ACME Certificates</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the menu name is fairly disruptive. Even just changing the case, it won't match in the code that adds/removes menu entries and some users will end up with two menu entries depending on what they do.

<tooltiptext></tooltiptext>
<section>Services</section>
<url>/acme/acme_certificates.php</url>
Expand Down
Loading