Major refactor of PFSenseModuleBase supporting generate_module pfsensible module generator #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opoplawski
force-pushed
the
module_base_extended
branch
2 times, most recently
from
0c926e7
to
4db67e9
Compare
opoplawski
force-pushed
the
module_base_extended
branch
from
4db67e9
to
0da13fe
Compare
opoplawski
force-pushed
the
module_base_extended
branch
from
0da13fe
to
70b0fc3
Compare
opoplawski
force-pushed
the
module_base_extended
branch
2 times, most recently
from
6fd5dd8
to
2931af2
Compare
- Allow for managing root_elt, elements - Add _find_this_element_index - Handle no existing elements - Implement _create_target and _find_target for node
…; _find_target only for root_is_exclusive == False
…clusive affects _copy_and_add_target(); _get_obj_name() uses key
- Add url parameter, deprecate address for urltable/urltable_ports - Use map_param_if and param_force
Remove unneeded test for type presence, don't mark it default
…e; Detect "type"; Scrape more web help text
…do not create different types of elements
…elf.elements in _copy_and_add_target - needed by some modules like user
… validating - implement _validate_params
- Add --name-param, and default to key - Strip 'manage' from url for module name - Detect lists in XML - Better list doc/example
…g support for older pfsense
- Handle root paths - Make diff['after'] reflect _remove_deleted_params - Allow map_param to move items into nested dictionaries - Fix handling lack of 'state' - Fix bool_style - Allow passing obj to params_to_obj - Remove bool params from obj, unset bools from parameters - Add fail message for not finding package
- Use bool_values, set root - targetip -> target for pfSense 2.7.1 pf+ 23.09 - Add diff support
opoplawski
force-pushed
the
module_base_extended
branch
from
2931af2
to
c6a6a78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.