Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactor of PFSenseModuleBase supporting generate_module pfsensible module generator #112

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

Major refactor of PFSenseModuleBase supporting generate_module pfsensible module generator #112

wants to merge 62 commits into from

Commits on Apr 29, 2024

  1. [module_base] Refactor 

    - Allow for managing root_elt, elements
- Add _find_this_element_index
- Handle no existing elements
- Implement _create_target and _find_target for node
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c6933dd View commit details
    Browse the repository at this point in the history

  2. [pfsense_cert] Use expanded PFSenseModuleBase

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5cf4c74 View commit details
    Browse the repository at this point in the history

  3. [pfsense_ca] Use expanded PFSenseModuleBase

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4a67cda View commit details
    Browse the repository at this point in the history

  4. [module_base] Allow setting root_is_exclusive; self.obj default to {}… 

    …; _find_target only for root_is_exclusive == False
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d7b929c View commit details
    Browse the repository at this point in the history

  5. [pfsense_alias] Use expanded PFSenseModuleBase

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fe33ad8 View commit details
    Browse the repository at this point in the history

  6. [module_base] Add key, root_is_exclusive defaults to True; root_is_ex… 

    …clusive affects _copy_and_add_target(); _get_obj_name() uses key
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    dbc449d View commit details
    Browse the repository at this point in the history

  7. [pfsense_interface_group] Use expanded PFSenseModuleBase

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d7ca82f View commit details
    Browse the repository at this point in the history

  8. [pfsense_default_gateway] Use PFSenseModuleBase root

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f9185d9 View commit details
    Browse the repository at this point in the history

  9. [pfsense_gateway] Use expanded PFSenseModuleBase

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bb235e1 View commit details
    Browse the repository at this point in the history

  10. [pfsense_interface_group] Drop _get_obj_name()

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    22e40a8 View commit details
    Browse the repository at this point in the history

  11. [module_base] set name; allow update_php code

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    af6a85b View commit details
    Browse the repository at this point in the history

  12. [pfsense_alias] auto set name; drop _find_target, _update

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2397e58 View commit details
    Browse the repository at this point in the history

  13. [module_base] Implement basic _params_to_obj()

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e9370d4 View commit details
    Browse the repository at this point in the history

  14. [checks] Add name to check_name output for clarity with aggregate

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fd58189 View commit details
    Browse the repository at this point in the history

  15. [pfsense_alias] Refactor _params_to_obj() and add url 

    - Add url parameter, deprecate address for urltable/urltable_ports
- Use map_param_if and param_force
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2d1dd71 View commit details
    Browse the repository at this point in the history

  16. [module_base] Basic _log_fields() implementation

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    db0f352 View commit details
    Browse the repository at this point in the history

  17. [pfsense_alias] Use PFSenseModuleBase _get_obj_name and _log_fields 

    Remove unneeded test for type presence, don't mark it default
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    254360b View commit details
    Browse the repository at this point in the history

  18. [generate_module] Initial checkin

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ad5ecac View commit details
    Browse the repository at this point in the history

  19. [generate_module] Add author handling

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    998a629 View commit details
    Browse the repository at this point in the history

  20. [generate_module] Better name generation; Do not overwrite module fil… 

    …e; Detect "type"; Scrape more web help text
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8ed3cb6 View commit details
    Browse the repository at this point in the history

  21. [module_base] Add have_refid, create_default

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b2c7775 View commit details
    Browse the repository at this point in the history

  22. [pfsense_authserver_ldap] Use have_refid, create_default more PFSense… 

    …ModuleBase methods
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2d1ee75 View commit details
    Browse the repository at this point in the history

  23. [pfsense_module] Add _REQUIRED_IF

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1beca47 View commit details
    Browse the repository at this point in the history

  24. Add *.swp to .gitignore

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5c52c2d View commit details
    Browse the repository at this point in the history

  25. [generate_module] Refactor 

    - Drop .py
- Store files in tmpdir
- Option to keep tmpfile, overwrite output
- Use '-' in options
- Handle number and password inputs
- Collect min, step, and placeholder attributes
- Template fixes
- Collect info in params_full and merge
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    723bf26 View commit details
    Browse the repository at this point in the history

  26. [pfsense_authserver_ldap] Update copyright

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8c5953b View commit details
    Browse the repository at this point in the history

  27. [generate_module] Add --type-suffix option

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    031b2f7 View commit details
    Browse the repository at this point in the history

  28. [generate_module] Mark items required if they have "element-required"… 

    … class, add to REQUIRED_IF; Add key to PFSenseModuleBase init
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8a667b2 View commit details
    Browse the repository at this point in the history

  29. [generate_module] Scan php code

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f91f037 View commit details
    Browse the repository at this point in the history

  30. [module_base] Store refid in obj; Use diff["after"] for logging compa… 

    …rison instead of obj, handle bool better
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    814955a View commit details
    Browse the repository at this point in the history

  31. [pfsense_ca] Use PFSenseModuleBase _create_target, logging; Drop pfSe… 

    …nse < 2.5.0 support; Fix certificate in tests to not have extra newlines
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cd2b183 View commit details
    Browse the repository at this point in the history

  32. [module_base] Initial support for bool_values

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5f1be15 View commit details
    Browse the repository at this point in the history

  33. [pfsense_ca] Define CA_BOOL_VALUES

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    665648d View commit details
    Browse the repository at this point in the history

  34. [misc/pfsense_module.py.j2] fix - handle module_type better

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8f20ba2 View commit details
    Browse the repository at this point in the history

  35. [pfsense_module.py.j2] Generate compact ARGUMENT_SPEC as well; fix fo… 

    …r REQUIRED_IF
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8ad7928 View commit details
    Browse the repository at this point in the history

  36. [generate_module] Handle web pages with different input methods that … 

    …do not create different types of elements
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    633ef2e View commit details
    Browse the repository at this point in the history

  37. [module_base] Use root_elt.findall() instead of get_elements; Reset s… 

    …elf.elements in _copy_and_add_target - needed by some modules like user
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    295ae99 View commit details
    Browse the repository at this point in the history

  38. [pfsense_user] Use updated PFSenseModuleBase

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1df96cd View commit details
    Browse the repository at this point in the history

  39. [generate_module] Handle textarea; type_param -> args.type_param

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9069191 View commit details
    Browse the repository at this point in the history

  40. [module_base] Initialize instance vars; Add arg_route for parsing and… 

    … validating - implement _validate_params
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    42692a6 View commit details
    Browse the repository at this point in the history

  41. [module_base] Add map_param; Use ValueError to handle errors in valid… 

    …ate methods
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    edb2e85 View commit details
    Browse the repository at this point in the history

  42. [pfsense_user] Use PFSenseModuleBase parsing and validation

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    13b0e3f View commit details
    Browse the repository at this point in the history

  43. [generate_module] Add _CREATE_DEFAULT, _MAP_PARAM, _ARG_ROUTE, drop _… 

    …validate_params
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    71e9a5f View commit details
    Browse the repository at this point in the history

  44. [generate_module] First stab at pkg_edit paths

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4378b7a View commit details
    Browse the repository at this point in the history

  45. [generate_module] Start on package handling

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    40c8606 View commit details
    Browse the repository at this point in the history

  46. [generate_module] Enhancements 

    - Add --name-param, and default to key
- Strip 'manage' from url for module name
- Detect lists in XML
- Better list doc/example
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    61503bd View commit details
    Browse the repository at this point in the history

  47. [pfsense_shellcmd] Add module

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    59fab4b View commit details
    Browse the repository at this point in the history

  48. [generate_module] Enforce "." at end of descriptions

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ec59b80 View commit details
    Browse the repository at this point in the history

  49. [module_base] Add default arg_route for interface; Process all parame… 

    …ters again
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    396c0c6 View commit details
    Browse the repository at this point in the history

  50. [generate_module] Support for standard interface parser; stub in 

    validate
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a12ed88 View commit details
    Browse the repository at this point in the history

  51. [pfsense_alias] Use CREATE_DEFAULT for detail/descr

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c9c2ee3 View commit details
    Browse the repository at this point in the history

  52. [pfsense_nat_outbound] Use mutually_exclusive; Use arg_route; Add som… 

    …e tests
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6e73cd7 View commit details
    Browse the repository at this point in the history

  53. [pfsense_ipsec] Start using expanded PFSenseModuleBase; Start droppin… 

    …g support for older pfsense
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c6cb4f1 View commit details
    Browse the repository at this point in the history

  54. [module_base] Bugfixes and enhancements 

    - Handle root paths
- Make diff['after'] reflect _remove_deleted_params
- Allow map_param to move items into nested dictionaries
- Fix handling lack of 'state'
- Fix bool_style
- Allow passing obj to params_to_obj
- Remove bool params from obj, unset bools from parameters
- Add fail message for not finding package
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    95cd167 View commit details
    Browse the repository at this point in the history

  55. [pfsense_nat_outbound] Refactor 

    - Use bool_values, set root
- targetip -> target for pfSense 2.7.1 pf+ 23.09
- Add diff support
    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    efdb97a View commit details
    Browse the repository at this point in the history

  56. [args_route] Add NOTE, p2o_strip

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    91032dc View commit details
    Browse the repository at this point in the history

  57. [module_config_base] Add initial base module for configuration modules

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    011c8d5 View commit details
    Browse the repository at this point in the history

  58. [pfsense_setup] Use PFSenseConfigBaseModule; Drop pre 2.5.0 support

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    20c43a8 View commit details
    Browse the repository at this point in the history

  59. [generate_module] First stabe at config module

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5734adb View commit details
    Browse the repository at this point in the history

  60. [tests/plays] README

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    85b1249 View commit details
    Browse the repository at this point in the history

  61. [module_base] style

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    266ab05 View commit details
    Browse the repository at this point in the history

  62. [pfsense] Allow turning off debug in phpshell()

    @opoplawski
    opoplawski committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    c6a6a78 View commit details
    Browse the repository at this point in the history