Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlatArray and Text #1856

Draft
wants to merge 54 commits into
base: develop
Choose a base branch
from
Draft

FlatArray and Text #1856

wants to merge 54 commits into from

Commits on Oct 1, 2024

  1. Introduce Text type for BorrowDatum 

    This is a bit MVP-ish at the moment.
    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e7a9248 View commit details
    Browse the repository at this point in the history

  2. Template out FlatArray 

    Right now, it only needs to typecheck.
    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1ed08e0 View commit details
    Browse the repository at this point in the history

  3. impl BorrowDatum for FlatArray

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    40bb692 View commit details
    Browse the repository at this point in the history

  4. Sketch out some more fn for FlatArray

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    68815db View commit details
    Browse the repository at this point in the history

  5. Copy nulls_mut into FlatArray

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4e1004a View commit details
    Browse the repository at this point in the history

  6. Add FlatArray::nulls

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    aac87d7 View commit details
    Browse the repository at this point in the history

  7. Document FlatArray pub fns

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4934fd4 View commit details
    Browse the repository at this point in the history

  8. Oh that was wildly unsound

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    742bcf5 View commit details
    Browse the repository at this point in the history

  9. Fix imports

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    536c729 View commit details
    Browse the repository at this point in the history

  10. Add unsafe {} for unsafe fn

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    48b4933 View commit details
    Browse the repository at this point in the history

  11. Completely redesign BorrowDatum

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b9a33c3 View commit details
    Browse the repository at this point in the history

  12. Fix BorrowDatum for FlatArray && Text 

    Also comment out a shitton of code that doesn't compile anymore.
    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d845204 View commit details
    Browse the repository at this point in the history

  13. Make FlatArray typecheck

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ba5e73f View commit details
    Browse the repository at this point in the history

  14. Make FlatArray::len public as FlatArray::count

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1b91a9e View commit details
    Browse the repository at this point in the history

  15. Draft an ArrayIter

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e84d3d2 View commit details
    Browse the repository at this point in the history

  16. Pipe through RawArray in places

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e2ddff7 View commit details
    Browse the repository at this point in the history

  17. Finish unpacking the parts of the array

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    85ea44c View commit details
    Browse the repository at this point in the history

  18. So now that just works

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    684005c View commit details
    Browse the repository at this point in the history

  19. Remove now-irrelevant code

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6b3ec58 View commit details
    Browse the repository at this point in the history

  20. mark incomplete code as incomplete

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c0f0238 View commit details
    Browse the repository at this point in the history

  21. use bitvec for MVP again

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    55b7543 View commit details
    Browse the repository at this point in the history

  22. comment on iter_mut design problems

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    24c7648 View commit details
    Browse the repository at this point in the history

  23. Split FlatArray into unconditional and conditional impls

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f98cc2c View commit details
    Browse the repository at this point in the history

  24. fix doc link maybe

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    848f2bc View commit details
    Browse the repository at this point in the history

  25. Make PassBy less optional

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7cea9b7 View commit details
    Browse the repository at this point in the history

  26. Fixup text docs

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3fa0675 View commit details
    Browse the repository at this point in the history

  27. Address the TODO for Text

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fac7f1e View commit details
    Browse the repository at this point in the history

  28. Elaborate on the Text API

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    14c47ac View commit details
    Browse the repository at this point in the history

  29. Have a cow

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    df9d60d View commit details
    Browse the repository at this point in the history

  30. obtain more confidence

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3606a9a View commit details
    Browse the repository at this point in the history

  31. Round out FlatArray API

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ef7ac23 View commit details
    Browse the repository at this point in the history

  32. SqlTranslatable for &FlatArray

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    151af42 View commit details
    Browse the repository at this point in the history

  33. try to add some tests

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    89a1f27 View commit details
    Browse the repository at this point in the history

  34. test revision

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    10072ec View commit details
    Browse the repository at this point in the history

  35. fixup tests more

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a8ca379 View commit details
    Browse the repository at this point in the history

  36. fix all compile blockers for tests

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    960869e View commit details
    Browse the repository at this point in the history

  37. Fix all test issuues

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2ed093f View commit details
    Browse the repository at this point in the history

  38. note stopping point in array iteration

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ea31e20 View commit details
    Browse the repository at this point in the history

  39. partially implement iteration

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e2294dc View commit details
    Browse the repository at this point in the history

  40. impl ArrayIter::next fully 

    also remove irrelevant deny-null tests and fix remaining tests.
    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6fca1e3 View commit details
    Browse the repository at this point in the history

  41. fix up FlatArray for CStr

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e9ee7bd View commit details
    Browse the repository at this point in the history

  42. Add Dimensions support and another test

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4fbe8c4 View commit details
    Browse the repository at this point in the history

  43. Fixup another test

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    96b6d5d View commit details
    Browse the repository at this point in the history

  44. Use BorrowDatum::borrow_unchecked inside FlatArray

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b67f095 View commit details
    Browse the repository at this point in the history

  45. Move BorrowDatum interfaces to ptr::NonNull

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c75dd1e View commit details
    Browse the repository at this point in the history

  46. deny unsafe op in unsafe fn in all new code

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    82cb038 View commit details
    Browse the repository at this point in the history

  47. impl TextData

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    cc020d4 View commit details
    Browse the repository at this point in the history

  48. move some doc text

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    347e1fb View commit details
    Browse the repository at this point in the history

  49. typo in fn name

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    05ed23d View commit details
    Browse the repository at this point in the history

  50. Fixup docs a bit

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d69231f View commit details
    Browse the repository at this point in the history

  51. Add doc aliases

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f92a756 View commit details
    Browse the repository at this point in the history

  52. Add Iterator subtraits

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e2ba9ac View commit details
    Browse the repository at this point in the history

  53. publicize ArrayIter

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7bce001 View commit details
    Browse the repository at this point in the history

  54. make some cstrings prettier

    @workingjubilee
    workingjubilee committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    aaa6ed2 View commit details
    Browse the repository at this point in the history