Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BorrowDatum, FlatArray, and Text #1856

Open
wants to merge 67 commits into
base: develop
Choose a base branch
from
+1,083 −24
Open

BorrowDatum, FlatArray, and Text #1856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
80e0071
Add BorrowDatum for simple types
workingjubilee Feb 21, 2024
0a0efc4
Introduce Text type for BorrowDatum
workingjubilee Feb 23, 2024
5909fe6
Template out FlatArray
workingjubilee Feb 23, 2024
c5ea54e
impl BorrowDatum for FlatArray
workingjubilee Feb 24, 2024
12bf305
Sketch out some more fn for FlatArray
workingjubilee Feb 24, 2024
7eaf9d1
Copy nulls_mut into FlatArray
workingjubilee Feb 25, 2024
614b3bc
Add FlatArray::nulls
workingjubilee Feb 25, 2024
6ae38a3
Document FlatArray pub fns
workingjubilee Feb 26, 2024
709170d
Oh that was wildly unsound
workingjubilee Feb 26, 2024
ad0e0d8
Fix imports
workingjubilee Feb 26, 2024
a58b578
Add unsafe {} for unsafe fn
workingjubilee Feb 26, 2024
6236c75
Add this huge caveat to BorrowDatum
workingjubilee Feb 26, 2024
1ef3212
Completely redesign BorrowDatum
workingjubilee Feb 27, 2024
11fdf35
Fix BorrowDatum for FlatArray && Text
workingjubilee Feb 27, 2024
5e7e0ce
Make FlatArray typecheck
workingjubilee Feb 28, 2024
66d12de
Add some comments
workingjubilee Feb 28, 2024
4c90cfd
Fix unsafe enclosure
workingjubilee Mar 20, 2024
6510d23
Make FlatArray::len public as FlatArray::count
workingjubilee Mar 20, 2024
35d0ee6
Draft an ArrayIter
workingjubilee Mar 20, 2024
b15d028
Publicize some interfaces
workingjubilee Apr 12, 2024
da2884a
Pipe through RawArray in places
workingjubilee Apr 12, 2024
ef583e2
Finish unpacking the parts of the array
workingjubilee Apr 12, 2024
0a68723
So now that just works
workingjubilee Apr 12, 2024
60e1889
Remove now-irrelevant code
workingjubilee Apr 12, 2024
fc60c9c
mark incomplete code as incomplete
workingjubilee Apr 12, 2024
0af590f
use bitvec for MVP again
workingjubilee Apr 12, 2024
f5efa5c
comment on iter_mut design problems
workingjubilee Apr 12, 2024
6c49788
Split FlatArray into unconditional and conditional impls
workingjubilee Apr 12, 2024
5e0c91f
comment
workingjubilee Apr 15, 2024
b7d6a45
stop talking about versions in comments
workingjubilee Sep 11, 2024
dd6e937
fix doc link maybe
workingjubilee Sep 11, 2024
39ab4d5
The crown jewel of this entire exercise
workingjubilee Sep 11, 2024
9b775b0
Make PassBy less optional
workingjubilee Sep 13, 2024
6ba3e3b
Fixup text docs
workingjubilee Sep 26, 2024
c0f4255
Address the TODO for Text
workingjubilee Sep 26, 2024
ce19b71
Elaborate on the Text API
workingjubilee Sep 27, 2024
a528c0e
Have a cow
workingjubilee Sep 27, 2024
6c346cc
obtain more confidence
workingjubilee Sep 27, 2024
78f6d95
Round out FlatArray API
workingjubilee Sep 27, 2024
5951be9
SqlTranslatable for &FlatArray
workingjubilee Sep 27, 2024
3b6e37c
try to add some tests
workingjubilee Sep 27, 2024
9ff9889
minor tweak
workingjubilee Sep 27, 2024
2807e8d
test revision
workingjubilee Sep 27, 2024
fa4072a
fixup tests more
workingjubilee Sep 27, 2024
3018a98
Figure out the conflict
workingjubilee Sep 27, 2024
47f1766
fix all compile blockers for tests
workingjubilee Sep 27, 2024
ff65592
Fix all test issuues
workingjubilee Sep 27, 2024
8a9196e
note stopping point in array iteration
workingjubilee Sep 27, 2024
f54290f
partially implement iteration
workingjubilee Sep 27, 2024
911d71f
impl ArrayIter::next fully
workingjubilee Sep 28, 2024
bebebf8
tune up CStr impl
workingjubilee Sep 28, 2024
c888c8b
fix nullable case for BorrowDatum
workingjubilee Sep 28, 2024
95c36c9
fix up FlatArray for CStr
workingjubilee Sep 28, 2024
e0b83b3
Add Dimensions support and another test
workingjubilee Sep 28, 2024
4c0d5fa
Fixup another test
workingjubilee Sep 28, 2024
df5ecc8
Revise BorrowDatum a bit
workingjubilee Sep 28, 2024
b29ebdb
Add `BorrowDatum::borrow_unchecked`
workingjubilee Sep 28, 2024
cf6a8da
impl `BorrowDatum::borrow_unchecked`
workingjubilee Sep 28, 2024
cae7f30
Move BorrowDatum interfaces to ptr::NonNull
workingjubilee Sep 28, 2024
f3133ac
deny unsafe op in unsafe fn in all new code
workingjubilee Sep 28, 2024
65d503d
impl TextData
workingjubilee Sep 28, 2024
97e79a4
move some doc text
workingjubilee Sep 28, 2024
dafd7a9
typo in fn name
workingjubilee Sep 28, 2024
f2bb2b7
Remove unused trait
workingjubilee Sep 28, 2024
4e37b8e
Fixup docs a bit
workingjubilee Sep 28, 2024
d2241d7
Add doc aliases
workingjubilee Sep 28, 2024
46d9e78
Add Iterator subtraits
workingjubilee Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading