Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#43 #44 Added new presenters and added presenter names #45

Merged
merged 9 commits into from
May 21, 2024

Conversation

manciniedoardo
Copy link
Collaborator

Closes #43 Closes #44

@manciniedoardo
Copy link
Collaborator Author

@bms63 do you know who presented "An overview of {admiral}" in 2023? That's the only one for whom i could not find a presenter

Copy link

github-actions bot commented May 17, 2024

Code Coverage

Package Line Rate Health
admiraldiscovery 25%
Summary 25% (41 / 162)

@bms63
Copy link
Contributor

bms63 commented May 17, 2024

@bms63 do you know who presented "An overview of {admiral}" in 2023? That's the only one for whom i could not find a presenter

I do not know. I would ping the slack channel

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manciniedoardo ping me when this is ready for review and the CI/CD is passing. Thanks!

@manciniedoardo
Copy link
Collaborator Author

@ddsjoberg sorry, i had logged off without checking the outcome of the first round of checks 😆

I think i fixed most now, the final lintr stuff might need a small update as i think we deactivate those specific checks in the main admiral packages?

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@manciniedoardo manciniedoardo merged commit 2b5dd85 into main May 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update list of conference presentations Name(s) of presenter
3 participants