A Practical Guide For SQL Tuning

[dbsid]

First-time contributors' checklist

• I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

• master (the latest development version)
• v8.4 (TiDB 8.4 versions)
• v8.3 (TiDB 8.3 versions)
• v8.2 (TiDB 8.2 versions)
• v8.1 (TiDB 8.1 versions)
• v7.5 (TiDB 7.5 versions)
• v7.1 (TiDB 7.1 versions)
• v6.5 (TiDB 6.5 versions)
• v6.1 (TiDB 6.1 versions)
• v5.4 (TiDB 5.4 versions)
• v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

• This PR is translated from:
• Other reference link(s):

Do your changes match any of the following descriptions?

• Delete files
• Change aliases
• Need modification after applied to another branch
• Might cause conflicts after applied to another branch

[ti-chi-bot]

Hi @dbsid. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Yui-Song]

Should we also add a section about the schema design? For example, do not use auto-increment attribute if you need to specify a specific value for this column; do not use partition table when data were not cleaned up by partitions. :)

[dbsid]

I think after we put the best practice for the partition table online, we can add a schema design session and link to the partition table document

[time-and-fate]

And looks like the format and terminology also need improvement. Like

1. Wrap `` for column/table names, text from SQL text, texts from EXPLAIN ANALYZE, operator names, etc.
2. Unify the capitalizations. Like "hash join", "Hash Join", "HashJoin", "TOPN", "TopN", "TopN", "top-N", "Point Get", "Point_Get", etc.

[mjonss]

My review part 1. Good structure and clear explanations, only some minor suggestions, feel free to ignore :)

[mjonss]

Very good job with examples and explanations. I only have some minor questions and suggestions!

[ti-chi-bot]

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Very good job with examples and explanations. I only have some minor questions and suggestions!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mjonss]

Maybe @mjonss can check if we could/should add more details about partitioning

@dveeden I think this PR is big enough as-is, I create a follow up, #19578, instead.

[ti-chi-bot]

@Yui-Song: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.