-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A Practical Guide For SQL Tuning #19108
Open
dbsid
wants to merge
49
commits into
pingcap:master
Choose a base branch
from
dbsid:sql-tuning-best-practice
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+972
−5
Open
Changes from 34 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
843d61d
draft
dbsid 1edd274
draft 2
dbsid 7bae9c9
draft
dbsid bfe7da1
draft
dbsid 9553527
draft
dbsid 0bc72c1
draft
dbsid d91c1eb
draft
dbsid 24d0f91
draft
dbsid 50ae7e3
draft
dbsid ca106fa
draft
dbsid 9694500
draft
dbsid f6745b2
draft
dbsid f15a334
draft
dbsid e0092a5
Update sql-tuning-best-practice.md
dbsid b1a2187
Apply suggestions from code review
dbsid 866f82e
Apply suggestions from code review
dbsid 46fa81a
fix format
dbsid 6cde429
add variable link
dbsid fa0aea5
Apply suggestions from code review
dbsid c5735ef
Apply suggestions from code review
dbsid ef18d9a
fix indent with 4 spaces
dbsid 3671292
Apply suggestions from code review
dbsid 9d52617
Update sql-tuning-best-practice.md
dbsid 7d30239
include tiflash
dbsid 299aea9
add tiflash content
dbsid deec5e3
Apply suggestions from code review
dbsid 6158783
add the document purpose and links
dbsid 7e46611
Merge branch 'sql-tuning-best-practice' of https://github.com/dbsid/d…
dbsid 66ee361
fix indent format
dbsid 13dc573
fix CI
dbsid 92fbeae
fix title
dbsid 676c27a
fix format
dbsid f40b373
fix format
dbsid 011f7c2
fix the comments
dbsid 7920021
Update sql-tuning-best-practice.md
dbsid 824e176
Apply suggestions from code review
dbsid fd86934
address comments;
dbsid 73a23e1
address the comments
dbsid c8f7882
fix format
dbsid ad2efea
unify the terminology
dbsid 03b6659
simple the terminology
dbsid 153ff39
improve the formats
dbsid 7ffcae6
fix
dbsid 2dadad6
fix format
dbsid 8796972
Update sql-tuning-best-practice.md
Yui-Song d019eba
Merge pull request #1 from Yui-Song/fix-format
dbsid d7ce1e1
Merge remote-tracking branch 'upstream/master' into sql-tuning-best-p…
dbsid 15574bc
adjust TOC in Tuning guide
dbsid 74f2127
fix ci
dbsid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice. How was this generated? Could we make this part of the TiDB Dashboard?
This reminds me of:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I borrow this example and figure from the education team. it's interesting to make this available in TiDB Cloud.
This will greatly reduce the difficulty to read and understand the execution plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should involve a PM?