-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: Add retry limit of connection err in fine grained backup #57713
Conversation
Hi @RidRisR. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #57713 +/- ##
================================================
Coverage ? 71.2293%
================================================
Files ? 1467
Lines ? 423473
Branches ? 0
================================================
Hits ? 301637
Misses ? 101357
Partials ? 20479
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do we need a test to verify it's working as expected?
Unfortunately there is no handy infrastructure for testing fine grained, and it seems not so worthy to build one for a up to deprecate function. I impl a basic manual test for it. |
/test unit-test |
@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev2 |
@RidRisR: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
…ingcap#57713) (pingcap#58216)" This reverts commit c0b86a3. Signed-off-by: hillium <[email protected]>
What problem does this PR solve?
Issue Number: close #57449
Problem Summary:
The fine grained backup may fails into infinite retry when encounter disconnect err.
What changed and how does it work?
Add a retry limit of 3 to each store.
Check List
Tests
Try to make error in resp 3 times, will get:
Error: failed to connect to store 1 for 3 times: failed to connect to store 1: [BR:Common:ErrFailedToConnect]failed to make gRPC channels
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.