-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: Add retry limit of connection err in fine grained backup (#57713) #58348
base: release-6.5
Are you sure you want to change the base?
br: Add retry limit of connection err in fine grained backup (#57713) #58348
Conversation
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #58348 +/- ##
================================================
Coverage ? 73.6588%
================================================
Files ? 1097
Lines ? 353029
Branches ? 0
================================================
Hits ? 260037
Misses ? 76268
Partials ? 16724 |
This is an automated cherry-pick of #57713
What problem does this PR solve?
Issue Number: close #57449
Problem Summary:
The fine grained backup may fails into infinite retry when encounter disconnect err.
What changed and how does it work?
Add a retry limit of 3 to each store.
Check List
Tests
Try to make error in resp 3 times, will get:
Error: failed to connect to store 1 for 3 times: failed to connect to store 1: [BR:Common:ErrFailedToConnect]failed to make gRPC channels
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.