test(evmengine/keeper): add test cases for evmmsgs #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsystm
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal,
Narangde and
leeren
as code owners
principle followed in this commit - single responsibility principle - separation of concerns before: the evmEvents function's responsibilities - fetching logs from ethereum client - converting those logs to EVMEvent objects - verifying the converted events - sorting the events after this commit - fetching logs from ethereum client (others are delegated to other functions)
it is directly related to EVMEvent so it should be defined in tx.go
zsystm
force-pushed
the
zsystm/test/evmengine/keeper/evmmsgs
branch
from
68a4a5f
to
281ac4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increased coverage of evmmsgs to 91.7% and do some refactoring of
evmmsgs.goThis PR includes #106 and will be updated based on discussion result for #106
issue: #81