Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(evmengine/keeper): add test cases for evmmsgs #95

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

test(evmengine/keeper): add test cases for evmmsgs #95

wants to merge 6 commits into from

Commits on Sep 10, 2024

  1. add test cases for evmmsgs

    @zsystm
    zsystm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2231ee8 View commit details
    Browse the repository at this point in the history

  2. refactor evmmsgs 

    principle followed in this commit
- single responsibility principle
- separation of concerns

before: the evmEvents function's responsibilities
- fetching logs from ethereum client
- converting those logs to EVMEvent objects
- verifying the converted events
- sorting the events

after this commit
- fetching logs from ethereum client
(others are delegated to other functions)
    @zsystm
    zsystm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    12e387d View commit details
    Browse the repository at this point in the history

  3. fix ci

    @zsystm
    zsystm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0991d7a View commit details
    Browse the repository at this point in the history

  4. fix ci

    @zsystm
    zsystm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6947bce View commit details
    Browse the repository at this point in the history

  5. chore: update variable name

    @zsystm
    zsystm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f834ae9 View commit details
    Browse the repository at this point in the history

  6. move isSorted to types/tx.go 

    it is directly related to EVMEvent so it should be defined in tx.go
    @zsystm
    zsystm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    281ac4b View commit details
    Browse the repository at this point in the history