Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lexicon entries for BrickCommentsUpdate, BrowserActionRestrictedUrl, and CustomUserEvent #9230

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Oct 3, 2024

What does this PR do?

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (8318d74) to head (e8a9569).
Report is 337 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9230      +/-   ##
==========================================
+ Coverage   74.24%   74.83%   +0.58%     
==========================================
  Files        1332     1367      +35     
  Lines       40817    42197    +1380     
  Branches     7634     7893     +259     
==========================================
+ Hits        30306    31577    +1271     
- Misses      10511    10620     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 3, 2024

Playwright test results

passed  127 passed
flaky  7 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  18 hours, 16 minutes, 46 seconds
commit  e8a9569
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge-setup › setup/affiliated.setup.ts › authenticate with affiliated user
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
chrome › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › prevents host page styles from leaking into dialog
msedge › tests/workshop/createMod.spec.ts › can create a new mod from a yaml definition and update it

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

github-actions bot commented Oct 4, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@mnholtz mnholtz merged commit 63ec329 into main Oct 4, 2024
23 checks passed
@mnholtz mnholtz deleted the feature/mixpanel_lexicon_brick_comments_update branch October 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants