Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lexicon entries for BrickCommentsUpdate, BrowserActionRestrictedUrl, and CustomUserEvent #9230

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Add lexicon entries for BrickCommentsUpdate, BrowserActionRestrictedUrl, and CustomUserEvent #9230

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c145777
add entry for BrickCommentsUpdate
mnholtz Oct 3, 2024
93355fe
tweak description
mnholtz Oct 3, 2024
ee53f02
add entry for BrowserActionRestrictedUrl
mnholtz Oct 3, 2024
e8a9569
add entry for CustomUserEvent
mnholtz Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/telemetry/lexicon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const LexiconTags = {
PAGE_EDITOR: "page editor",
MOD_ACTIVATION: "mod activation",
EXTENSION_CONSOLE: "extension console",
MOD_RUNTIME: "mod runtime",
} as const;

type LexiconTag = ValueOf<typeof LexiconTags>;
Expand Down Expand Up @@ -86,6 +87,24 @@ export const lexicon: LexiconMap = {
'Triggered when a user successfully adds a brick to a Mod in the Page Editor via clicking "Add" or "Add brick" in the Add Brick modal.',
tags: [LexiconTags.PAGE_EDITOR],
},
BRICK_COMMENTS_UPDATE: {
description:
"Triggered when a user updates the brick comment in the 'comments' tab of the Data Panel in the Page Editor. More specifically, " +
"when a user modifies the comment and leaves the field.",
tags: [LexiconTags.PAGE_EDITOR],
},
BROWSER_ACTION_RESTRICTED_URL: {
description:
"Reported when a user sees the restricted webpage warning 'PixieBrix cannot access this page' when opening the " +
"PixieBrix sidebar on a restricted page, e.g. the Extension Console or a new browser tab.",
tags: [LexiconTags.MOD_RUNTIME],
},
CUSTOM_USER_EVENT: {
description:
"Event reported from the 'Send Telemetry' brick in a mod. Mod developers can customize the `eventName` " +
"property and add additional properties to this event at will.",
tags: [LexiconTags.MOD_RUNTIME],
},
};

/**
Expand Down
Loading