Change tile width dynamically to allow longer strings #56
Conversation
|
Thank you for your contribution! 🎉 |
|
Alright, I'll fix it up when I get home from work in a few hours |
The table will now draw to the longest length number with a small border of spaces Resolves #54
Default width of cell shall remain 4+2=6 characters width. Cell width and border string are calculated only when largestTile changes value when largestTileLength is greater than 4.
src/game.cpp
Outdated
| clearScreen(); | ||
| drawAscii(); | ||
| drawScoreBoard(std::cout); | ||
|
|
||
| int numlen = std::to_string(largestTile).length(); |
src/game.cpp
Outdated
| std::string border; | ||
| // Multiple cell border enum by 2 so it applies the same padding | ||
| // to both sides | ||
| for(int i = 0; i < numlen+( CELL_BORDER * 2); i++){ |
|
So, things are a bit confusing here with the authors of commits in this PR. |
|
My apologies @cawvyoct 😐! I saw a few things that could be counted as quick-fixes so I did it myself. I'll keep this in mind, thank you. |
| @@ -55,6 +55,8 @@ class Game { | |||
| ull score; | |||
| ull bestScore; | |||
| ull largestTile; | |||
| int cellWidth; | |||
| std::string horizontalBorder; | |||
There was a problem hiding this comment.
Better practice would be:
- A free anonymous-namespace function that outputs a horizontalBorder string.
| int largestTileLength = std::to_string(largestTile).length(); | ||
| if (cellWidth > MINIMUM_CELL_WIDTH) { | ||
| cellWidth = largestTileLength; | ||
| horizontalBorder.append("─"); |
There was a problem hiding this comment.
With an anonymous-namespace free function, you can take in a parameter [length] and the string returned would be a string of the [horizontalBorder character].
| @@ -228,7 +220,7 @@ void Game::drawBoard() { | |||
| std::cout << " └"; | |||
|
|
|||
| for (int i = 0; i < gameBoardPlaySize; i++) { | |||
| std::cout << border; | |||
| std::cout << horizontalBorder; | |||
There was a problem hiding this comment.
Everytime you want to draw the [horizontalBorder string], you would just call the function.
| bestScore(0), moveCount(-2), largestTile(2), stateSaved(false), | ||
| noSave(false) {} | ||
| bestScore(0), moveCount(-2), largestTile(2), cellWidth(4), | ||
| horizontalBorder("──────"), stateSaved(false), noSave(false) {} |
There was a problem hiding this comment.
This means one would not need the [horizontalBorder] member-variable.
|
@plibither8 Do you want to handle these changes or shall I? I don't mind either way, I just don't want us both to accidentally push upstream at once |
|
Go ahead, I guess it's better since you've created the PR. I have some other work right now, won't be able to work on this until later. Thanks 👍 |
constexpr int CELL_BORDER = 1;This works too, however enums are great for newer developers to understand that some variables have a group context together. |
|
Hi @Scronkfinkle, Dynamic-width tiles are still very much a challenge open for you if you wish. I think even when more refactored code lands into the codebase, your skill / help would be fine in completing it. 🐱 |
The table will now draw to the longest length number with a small border of spaces
Resolves #54