Wind Charge Implementation

[CJMustard1452]

Introduction

Implementation for the 1.21.0 Wind Charge

Relevant issues

N/A

Details

• Non-iron doors and trapdoors are flipped.
• Fence gates are flipped.
• Buttons are pressed.
• Levers are flipped.
• Bells are rung and swung.
• Chorus flowers and pointed dripstone blocks break, dropping in item form.
• Lit candles (both standalone and on cake) are extinguished.

Wind charges can be deflected if hit with another projectile or a melee attack, similar to ghast fireballs.
Wind charges are distance attenuated by liquids such as water and lava. They also appear to fly in a straight line, similar to fireballs
Wind charges are set to despawn after five minuets due to the gravity less nature of the entity.

https://minecraft.wiki/w/Wind_Charge

Changes

One method has been added to pocketmine\block\Block:

	/**
	 * Called when this block is updated by a state altering projectile in the world.
	 *
	 * @param pocketmine\entity\projectile\Projectile $projectile The projectile affecting the block.
	 */
	public function onProjectileInteraction(pocketmine\entity\projectile\Projectile $projectile) : void {

	}

Both class' for the Wind Charge item and Projectile have been created:

• pocketmine\entity\projectile\WindCharge.php
• pocketmine\item\WindCharge.php

One class has been created to handle the wind charge explode particle:

• pocketmine\world\particle\WindExplosionParticle.php

One class has been added to handle wind charge burst sound:

• pocketmine/world/sound/WindChargeBurstSound.php

The Wind Charge has been implemented as a vanilla item.
The Wind Charge Entity has been implemented as an Entity.

API changes

N/A

Behavioural changes

N/A

Backwards compatibility

N/A

Follow-up

N/A

Tests

I tested this PR by doing the following (tick all that apply):

• Writing PHPUnit tests (commit these in the tests/phpunit folder)
• Playtesting using a Minecraft client (provide screenshots or a video)
• Writing a test plugin (provide the code and sample output)
• Other (provide details)

Behavior With Other Blocks

Behavior.mp4

Behavior With Players (shows less effective under water.)

minecraft-2024-06-26-02-45-54-online-video-cuttercom-1_T9Woq9fd.mp4

Behavior Multi Hit

Minecraft.2024-06-26.03-18-39.mp4

[CJMustard1452]

Newly re-based PR...

[dadodasyra]

Except this it looks good to me, I don't understand why does Github web preview looks like indentation is off but it seems not to.

[ipad54]

It's seems like fall distance compensation is missing.

In vanilla, a player launched by wind charges shot by a player accumulates fall damage only when falling below the Y level where the wind burst hit.

[ShockedPlot7560]

need to check if its not pressed

[CJMustard1452]

$this->pressed(); in this context, thereby extending the pushed duration if already down, I do not see a need to change this, thoughts?

[ShockedPlot7560]

by checking that it is not activated, you will avoid extra sound.

[ShockedPlot7560]

So, if the projectile hit the upper one, no toggle will be happened ?

[CJMustard1452]

Yeah, this is my best attempt at handling this issue, if it hits both blocks the door hits, (open, close)

[ShockedPlot7560]

Can be useful before toggling to check the other state. If its not the same as ours when projectile hits, we can ignore ? Just a theory

[CJMustard1452]

feels a little hacky to be honest

[ShockedPlot7560]

Maybe hacky but can avoid to have unexpected side effect if only the top block is hitten by the effect area.

[ShockedPlot7560]

Would be better to moove it into the condition above?

[ShockedPlot7560]

An additional comment: isn't it better to check whether it's a windcharge by the typeId rather than the instance?