refactor: Allocate proper buffer #19357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
|
Superseded. |
|
Not actually superseded, fixes a different unsoundness... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19357 +/- ##
==========================================
- Coverage 80.24% 80.19% -0.05%
==========================================
Files 1523 1523
Lines 209545 209839 +294
Branches 2434 2434
==========================================
+ Hits 168148 168282 +134
- Misses 40842 41002 +160
Partials 555 555 ☔ View full report in Codecov by Sentry. |
orlp
reviewed
Oct 21, 2024
| @@ -174,7 +175,7 @@ pub(super) unsafe fn take_unchecked<O: Index>( | |||
| let n_idx = indices.len(); | |||
| let total_bytes = bytes_per_element * n_idx; | |||
|
|
|||
| let mut buf = aligned_vec(total_bytes); | |||
| let mut buf = aligned_vec(leaves.dtype(), total_bytes); | |||
There was a problem hiding this comment.
Technically unsound if a panic occurs between the moment this is allocated until it is forgotten. Should probably wrap it in a ManuallyDrop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.