-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anglo_Saxon_Project #104
Anglo_Saxon_Project #104
Conversation
OK, perhaps Joscha can still provide the Plink data in time, otherwise it's also in AADR (embarrassingly). |
Please make this a draft PR for now. |
Hi @93Boy. I have uploaded the genetic data. It contains 8 more rows than your original Janno file. I have now adapted the order of rows in the Janno file to the order in the genotype data. I have added rows with "n/a" for those individuals that were listed in the genotype data but not in the Janno. Perhaps you can check again in the paper tables whether you find information for those samples and add it. If not, please ask Joscha Gretzinger. Here are a number of todos:
If anything is unclear, please ask me and I can inquire further. |
Sure Stephan I will start working on this now |
Hello Stephan, I went through the data and found those points.
|
Yes I think perhaps it's easiest if you just then adapt the janno file to the ind-groups |
|
Hmm, but that means that EAS003 is part of the genotype files then? That's bad... then we need to remove those I suppose. |
May I remove these from the genotype data? |
Hello Stephan, I received an update from Joscha. As a summary we can include all of them in the Poseidon package, All the entries except EAS003, are re-sequences from the Schiffels et al. 2016 paper. May I extract that information from your paper? |
Yes of course. Please do so. Once you have filled whatever you can, please report back. I'm happy to fill anything you don't know. |
@stschiff I have filled missing data fields from your 2016_SchiffelsNatureCommunications. I would like to note the below points.
|
I checked, and it seems that EAS003 was in fact not removed from the genotype data, only from the Janno File. I will put it back |
OK, I've gone through this. As written above, EAS003 was still part of the genotype data, so I put it back into the Janno and filled the necessary fields in consultation with Joscha. @93Boy, Please work on the following:
For individuals I0161, I0159, I0769, I0773, I0774, I0777, I0157: These are the ones that you took from Schiffels_2016. I have now some new information on these: They are in fact Capture datasets from Davids Lab of the same individuals that were published in 2016, but it's new datasets. So please
Finally, please convert the genotype data to Plink using Let me know if you encounter problems. |
@93Boy do you have an update for us? |
Ooookay, so I have finally finalised this Pull Request. It needs to still be reviewed by Joscha Gretzinger, though, which I'll take care of. For the record, here are a few things that I did:
|
Specific points for Joscha to check:
|
@93Boy I think it would be great if you could start filling in the rest of the relationships. I have created the |
@stschiff Yes I have begun to working on the relationship data in a sub branch as you have mentioned |
@stschiff I have updated all the kinship information I have found in supplementary documents |
I think you haven't pushed your changes, @93Boy |
@stschiff I have created a sub branch named |
Great, I'll take a look. |
25760bf
to
cdab216
Compare
OK, after having first merged #136 and then realised that the kinship needs more work, I decided to roll-back this PR to the state before the kinship information was merged. I will now await the validation pass (it passed locally) and then merge this in. Some points need addressing by Joscha Gretzinger, but I do not want to wait further and instead then have him look through the merged package and eventually provide an update. It's such a big package that I find it important that it gets out now. |
77751b3
to
183d0c2
Compare
OK, so I think this is ready to be merged. @AyGhal do you want to have a look? There are some points, listed above, which need to be checked by Joscha, but given that some time has passed I suggest to merge this now and then release an update once Joscha has checked some of the details in the Janno. This is a large package and it needs to be published yesterday. |
I had a quick look and it seems okay. |
This is a draft .Janno file based on available data.