Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2022_Kennett_Belize #29

Merged
merged 13 commits into from
Dec 20, 2024
Merged

Add 2022_Kennett_Belize #29

merged 13 commits into from
Dec 20, 2024

Conversation

TCLamnidis
Copy link
Member

@TCLamnidis TCLamnidis commented Nov 26, 2024

Adds/Updates 2022_Kennett_Belize

Linked to poseidon-framework/minotaur-recipes#37

New packages added to the minotaur archive are always published in version 1.0.0. This means that nay and all changes made to the package during the review process, should only bump the Minor or Patch version of the package.

PR checklist:

  • This package contains a BibTex file.
  • If this package already exists in the community archive:
    • The information from the community archive was used to fill-in empty janno fields.
    • The commands used for the fill-in and any tool versions are kept track of in the README file.
  • Country information is also present in the Country_ISO column.

Once the Pull Request has passed the review process, ensure the package version is bumped once more before publishing with:

trident rectify -d <package_dir> --logText 'Bump version for release' --packageVersionMajor --checksumAll

@TCLamnidis TCLamnidis added the help wanted Extra attention is needed label Nov 26, 2024
@TCLamnidis TCLamnidis added Final review needed This PR needs its final review before going live and removed help wanted Extra attention is needed labels Dec 18, 2024
Copy link
Member

@nevrome nevrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The description field in the POSEIDON.yml file is still set to Empty package template. Please add a description.

@TCLamnidis TCLamnidis merged commit b0c79cb into main Dec 20, 2024
1 check passed
@TCLamnidis TCLamnidis deleted the 2022_Kennett_Belize branch December 20, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final review needed This PR needs its final review before going live
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants