-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2022_Kennett_Belize #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.janno for 2022_Kennet_Belize
TCLamnidis
added
Final review needed
This PR needs its final review before going live
and removed
help wanted
Extra attention is needed
labels
Dec 18, 2024
nevrome
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The description
field in the POSEIDON.yml file is still set to Empty package template. Please add a description
.
…inotaur-archive into 2022_Kennett_Belize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds/Updates
2022_Kennett_Belize
Linked to poseidon-framework/minotaur-recipes#37
New packages added to the minotaur archive are always published in version
1.0.0
. This means that nay and all changes made to the package during the review process, should only bump theMinor
orPatch
version of the package.PR checklist:
Country
information is also present in theCountry_ISO
column.Once the Pull Request has passed the review process, ensure the package version is bumped once more before publishing with: