Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colour customisation to layout editor #29936

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Merge branch 'master' into skinning-colour-customisation

4f57a67
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Add colour customisation to layout editor #29936

Merge branch 'master' into skinning-colour-customisation
4f57a67
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Sep 24, 2024 in 0s

10488 passed, 1 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10563 tests were completed in 2799s with 10488 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations 11✅ 1❌ 19s

❌ osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations

✅ TestBestRulesetIsRecommended
✅ TestBestRulesetIsRecommended
✅ TestConstructor
✅ TestConstructor
✅ TestCorrectStarRatingIsUsed
❌ TestCorrectStarRatingIsUsed
	"recommended beatmap displayed" timed out
✅ TestCurrentRulesetIsRecommended
✅ TestCurrentRulesetIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestSecondBestRulesetIsRecommended
✅ TestSecondBestRulesetIsRecommended

Annotations

Check failure on line 541 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations ► TestCorrectStarRatingIsUsed

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  "recommended beatmap displayed" timed out
Raw output
"recommended beatmap displayed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)