Add unistd.h to libzip to prevent build failure with Xcode 14.3 #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents build failure on Xcode 14.3
Prevents build failure with Xcode 14.3
Prevents build failure with Xcode 14.3
shinra-electric
changed the title
|
Isn't contrib 3rd party? so existing repo? shouldn't we upgrade to more up-to-date and propose fix to there repo? |
|
Well yes, but it is part of this repo. That usually means that there are changes from upstream. If we are just using stock libzip shouldn't we have it as a submodule or something? |
6 tasks
|
Closing, as PR #2117 does the same thing and has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Without this PR, Premake will fail to build using Xcode 14.3. This PR adds
unistd.hto three files in libzip which will allow the build to succeed.How does this PR change Premake's behavior?
Allows the build to succeed.
Are there any breaking changes? Will any existing behavior change?
Not that I'm aware of.
Anything else we should know?
From my understanding,
unistd.his for posix-compliant OSes, so ideally I should ifdef these changes so they are not added to non-posix OSes.zip_close.chas the check#ifdef HAVE_UNISTD_Hwhich I thought would be appropriate, but building still fails when using this.If anyone can suggest a better define, let me know and I'll add it.