Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require unistd.h for macosx in libzip #2117

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

nickclark2016
Copy link
Member

What does this PR do?

Resolves implicit symbol in libzip and closes #2092

How does this PR change Premake's behavior?

N/A

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016
Copy link
Member Author

This would close #2060 as well.

@nickclark2016
Copy link
Member Author

I'll merge this assuming the discussion in #2092 resovles in a way that we can close. Future action to update libzip.

@nickclark2016 nickclark2016 merged commit 7247aad into premake:master Aug 14, 2023
12 checks passed
@nickclark2016 nickclark2016 deleted the issues/2092 branch August 14, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Premake build fails on Xcode 14.3
2 participants