.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

lolrobbe2 · 2024-10-07T17:41:34Z

What does this PR do?

Add support for setting .NET sdk using dotnetsdk option. (only on new format projects otherwise just use the defautl)

Web
Razor
Worker
Blazor (BlazorWebAssembly)
WindowsDesktop
default (Microsoft.NET.Sdk)

How does this PR change Premake's behavior?

adds a new option called dotnetsdk

Anything else we should know?

Add any other context about your changes here.

Did you check all the boxes?

Focus on a single fix or feature; remove any unrelated formatting or code changes
Add unit tests showing fix or feature works; all tests pass
Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
Follow our coding conventions
Minimize the number of commits
Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

for some reason it took the commits from my previous pr (add C# documentation file to) i didn't change these files tho!

closes #2288

(functional result stays the same)

modules/vstudio/vs2005_dotnetbase.lua

src/_premake_init.lua

Jarod42 · 2024-10-08T17:04:02Z

website/docs/dotnetsdk.md

+
+
+## mstest ##
+to make the MSTest sdk work you need to add the version to `global.json`:


Would it make sense to generate that file too?

yes i was thinking about that but how would i make it so you could specify the version? or do i just have a default version and tell people where they can change it! and code for writing the file as i am not familliar with the file api's of premake

Not sure if it is adapted but something like MSTest-3.6.1 might be an option
if version are limited, you might hard-code them, else extract version after '-' is also possible.

Co-authored-by: Joris Dauphin <[email protected]>

…tion to new dedecated function! (global.json file writing not workin)

also made it so it does not overwrite global.json when it already exists potentially overwriting variables

src/_premake_init.lua

modules/vstudio/vs2005_dotnetbase.lua

website/docs/dotnetsdk.md

samsinsane · 2024-10-09T07:53:56Z

website/docs/dotnetsdk.md

+
+
+## mstest ##
+to make the MSTest sdk work you need to add the version to `global.json`:


Suggested change

to make the MSTest sdk work you need to add the version to `global.json`:

To make the MSTest SDK work you need to add the version to `global.json`:

Also, according to this you don't need to use global.json, you can have the version in the .csproj with the SDK.

yes that is correct but specifiying it becomes a little hard so i decided on the global.json route

samsinsane · 2024-10-09T07:54:26Z

website/docs/dotnetsdk.md

+}
+```
+:::warning
+`global.json` needs to be located in the same folder as your solution


Suggested change

`global.json` needs to be located in the same folder as your solution

`global.json` needs to be located in the same folder as your solution.

samsinsane · 2024-10-09T07:55:51Z

website/docs/dotnetsdk.md

+Visual studio is the only toolset currently supported.
+
+### Examples ###
+use the web sdk


This description is unnecessary, the example is self-documenting.

samsinsane · 2024-10-09T07:58:06Z

modules/vstudio/tests/cs2005/test_dotnetsdk.lua

@@ -0,0 +1,101 @@
+--
+-- tests/actions/vstudio/cs2005/test_dotnetsdk.lua
+-- Test DocumentationFile feature Visual Studio 2005+ C# project.


This wasn't updated.

modules/vstudio/tests/cs2005/test_dotnetsdk.lua

modules/vstudio/vs2005_dotnetbase.lua

website/docs/dotnetsdk.md

src/_premake_init.lua

modules/vstudio/vs2005_dotnetbase.lua

Jarod42 · 2024-10-09T14:14:42Z

modules/vstudio/tests/cs2005/test_dotnetsdk.lua

+<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
+		]]
+	end
+	function suite.testMSTest()


global.json part is not tested

how would i go about that?

Issue is probably that global.json doesn't follow other file generation and so dotnetbase.netcore.dotnetsdk would be misplaced...

would you happen to know where i can find another example of this file generating?

…in test case but is written in normal ussage

…ause the file is created fine when using in non test environment! also tried changing dir to _TESTS_DIR to no avail.

lolrobbe2 · 2024-10-09T20:32:37Z

Could it be that tests are blocked from creating files? wich would explain why the file is not found!

robbe beernaert and others added 30 commits June 29, 2023 17:49

added C# documentationFile feature

34a8b7b

wrote unit tests for C# documentationFile

42128d0

removed null opt to not enable documentationFile

753b78e

add documentationFile documentation

c74f42f

add documentationFile documentation

3c168d9

resolve merge confflict with documentation

6a5bee2

added some extra info for custom dir

3c60b2c

implemented comments

aa6bac0

fixed title

faae641

fixed spelling + addd test

17a9b04

fixed spelling + addd test

ac1b8cb

Merge branch 'master' of https://github.com/lolrobbe2/premake-core

652ab29

improved grammar / capitalization

a228108

changed styling of the documentation

fe84d57

changed docs to fit api

e831595

added MSFT links to See Also

dbd70b5

fixed capitalization

19715dd

changed wording/ capitalization of documentation

ce31e60

removed the slashes!

40167fe

added documenationfile to the sidebar

9707d8f

Rename documentationFile.md to documentationfile.md

3533b2a

merged from master

36903cc

added support for newer <GenerateDocumentationFile> tag

f50609c

(functional result stays the same)

Merge branch 'master' of https://github.com/premake/premake-core

912aac2

changed tests

44165f5

changed default from documentationfile "" to documentationfile(true)

ef4ac4d

changed documentation to match!

3ec3b33

changed availability in docs for documentationfile.md

28374f7

Merge branch 'master' of https://github.com/premake/premake-core

1946ed0

added support to select .NET sdk in visual studio.

d0bd40f

Beernaert Robbe added 2 commits October 7, 2024 19:37

updated sidebar.js

29fe49f

added comma!

8cf3ccc

Jarod42 reviewed Oct 8, 2024

View reviewed changes

lolrobbe2 and others added 2 commits October 8, 2024 19:12

use map instead of ugly if else statement.

63964d8

Co-authored-by: Joris Dauphin <[email protected]>

tried to cleanup projectElement function to extract the wpf sdk selec…

76b9709

…tion to new dedecated function! (global.json file writing not workin)

lolrobbe2 requested a review from Jarod42 October 8, 2024 17:43

Beernaert Robbe added 2 commits October 8, 2024 19:59

put the api.register next to dotnetframework register function

b409321

figured out the file logic

67b90c3

also made it so it does not overwrite global.json when it already exists potentially overwriting variables

samsinsane requested changes Oct 9, 2024

View reviewed changes

Beernaert Robbe added 4 commits October 9, 2024 12:04

implemented feedback from samsinsane

e0a4f80

added a test for WPF flag

06ce5b6

updated the dotnetsk options in the docs

bff0fa9

fixed WindowsDesktop type and added Default to docs

3698bec

lolrobbe2 requested a review from samsinsane October 9, 2024 10:42

Jarod42 reviewed Oct 9, 2024

View reviewed changes

modules/vstudio/vs2005_dotnetbase.lua Outdated Show resolved Hide resolved

modules/vstudio/vs2005_dotnetbase.lua Outdated Show resolved Hide resolved

website/docs/dotnetsdk.md Outdated Show resolved Hide resolved

src/_premake_init.lua Outdated Show resolved Hide resolved

Jarod42 reviewed Oct 9, 2024

View reviewed changes

modules/vstudio/vs2005_dotnetbase.lua Outdated Show resolved Hide resolved

implemented feedback from Jarod42

566a587

lolrobbe2 requested a review from Jarod42 October 9, 2024 13:21

Jarod42 reviewed Oct 9, 2024

View reviewed changes

lolrobbe2 requested a review from Jarod42 October 9, 2024 14:54

Beernaert Robbe added 2 commits October 9, 2024 18:11

added test but test is not fully correct because file is not written …

9fe2531

…in test case but is written in normal ussage

at this point when running tests file creation is blocked i think bec…

1a25b9f

…ause the file is created fine when using in non test environment! also tried changing dir to _TESTS_DIR to no avail.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

lolrobbe2 commented Oct 7, 2024 •

edited

Loading

Jarod42 Oct 8, 2024

lolrobbe2 Oct 8, 2024

Jarod42 Oct 9, 2024

samsinsane Oct 9, 2024

lolrobbe2 Oct 9, 2024

samsinsane Oct 9, 2024

samsinsane Oct 9, 2024

samsinsane Oct 9, 2024

Jarod42 Oct 9, 2024

lolrobbe2 Oct 9, 2024

Jarod42 Oct 9, 2024

lolrobbe2 Oct 9, 2024

lolrobbe2 commented Oct 9, 2024



		## mstest ##
		to make the MSTest sdk work you need to add the version to `global.json`:

	`global.json` needs to be located in the same folder as your solution
	`global.json` needs to be located in the same folder as your solution.

.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

Are you sure you want to change the base?

.NET C# no way to enable different .NET sdk's on .netcore projects! #2289

Conversation

lolrobbe2 commented Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lolrobbe2 commented Oct 9, 2024

lolrobbe2 commented Oct 7, 2024 •

edited

Loading