Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET C# no way to enable different .NET sdk's on .netcore projects! #2289
base: master
Are you sure you want to change the base?
.NET C# no way to enable different .NET sdk's on .netcore projects! #2289
Changes from 32 commits
34a8b7b
42128d0
753b78e
c74f42f
3c168d9
6a5bee2
3c60b2c
aa6bac0
faae641
17a9b04
ac1b8cb
652ab29
a228108
fe84d57
e831595
dbd70b5
19715dd
ce31e60
40167fe
9707d8f
3533b2a
36903cc
f50609c
912aac2
44165f5
ef4ac4d
3ec3b33
28374f7
1946ed0
d0bd40f
29fe49f
8cf3ccc
63964d8
76b9709
b409321
67b90c3
e0a4f80
06ce5b6
bff0fa9
3698bec
566a587
9fe2531
1a25b9f
d30ae4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should end with a colon and should have an empty line after it before the starting the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to generate that file too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i was thinking about that but how would i make it so you could specify the version? or do i just have a default version and tell people where they can change it! and code for writing the file as i am not familliar with the file api's of premake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it is adapted but something like
MSTest-3.6.1
might be an optionif version are limited, you might hard-code them, else extract version after '-' is also possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, according to this you don't need to use
global.json
, you can have the version in the.csproj
with the SDK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that is correct but specifiying it becomes a little hard so i decided on the global.json route
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is unnecessary, the example is self-documenting.