Add UPDATE support for Iceberg #24281
Draft
+988
−292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, the UpdateOperator would throw an exception stating that there was no valid page source. This occurs because the driver which is responsible for setting the UpdateablePageSource never calls the proper method due to never receiving any inputs. This now handles the case where the page source is never set by returning an EmptySplitPageSource
This commit allows users to perform row-level updates when using the Iceberg connector with Java executors. This is achieved by improving on the IcebergUpdatablePageSource to implement the updateRows method. The implementation passes a generated row ID column as a field in the page required by updateRows. Then during updateRows, generated a positionDelete file entry for the row ID, and also writes the row's updated value to a new page sink for the newly updated data. These new files are then commited in a rowDelta transaction within the Iceberg connector metadata after processing is complete. Co-Authored-By: Nidhin Varghese <[email protected]> Co-Authored-By: Anoop V S <[email protected]>
prestodb-ci
requested review from
a team,
anandamideShakyan and
ShahimSharafudeen
and removed request for
a team
- failing equality delete test - typo in assertion on test update with predicate
ZacBlanco
force-pushed
the
upstream-iceberg-update
branch
from
e56fc7c to
f0a29a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support in the Iceberg connector for
UPDATEoperations.Motivation and Context
Row-level table
UPDATEsupportImpact
update_modetable property on Iceberg tablesUPDATE <x> SET ... WHERE ...queries can now run successfullyTest Plan
Comprehensive set of unit tests for different tables and column types.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.