Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional arguments for rosbridge port and websocket external po… #20

Open
wants to merge 1 commit into
base: noetic
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions launch/teleop.launch
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@
<arg name="keyboard_teleop" value = "0" />

<!-- Start up websocket for docker container foxglove -->
<arg name="_rosbridge_port" default="$(optenv ROSBRIDGE_PORT)" />
<arg name="_rosbridge_websocket_external_port" default="$(optenv ROSBRIDGE_WEBSOCKET_EXTERNAL_PORT)" />

<group if="$(arg foxglove_teleop)">
<include file="$(find rosbridge_server)/launch/rosbridge_websocket.launch" >
<arg name="port" value="9090"/>
<include file="$(find rosbridge_server)/launch/rosbridge_websocket.launch" >
<arg name="port" value="$(eval _rosbridge_port if _rosbridge_port else 9090)"/>
<arg name="websocket_external_port" value="$(eval _rosbridge_websocket_external_port if _rosbridge_websocket_external_port else None)"/>
</include>
</group>

Expand Down