Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): add unicorn/prefer-logical-operator-over-ternary rule #2871

Merged

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Sep 19, 2023

To avoid to have to many changes by enabling plugin:unicorn/recommended, I choose to enable some rule one-by-one.

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-logical-operator-over-ternary.md

Part of #2824

⚠️ For the code coverage, it was already the case before this PR.

Covers #2742

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

🎊 PR Preview a7e979e has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2871.surge.sh

🕐 Build time: 0.02s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

🎊 PR Preview a7e979e has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2871.surge.sh

🕐 Build time: 0.014s

🤖 By surge-preview

@csouchet csouchet changed the title chore(eslint): add prefer-logical-operator-over-ternary rule chore(eslint): add unicorn/prefer-logical-operator-over-ternary rule Sep 20, 2023
@csouchet csouchet force-pushed the 2742-add_unicorn/prefer-logical-operator-over-ternary_rule branch from a7e979e to 74e49bd Compare September 21, 2023 12:37
@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Sep 21, 2023
@csouchet csouchet marked this pull request as ready for review September 21, 2023 12:41
@process-analytics process-analytics deleted a comment from sonarcloud bot Sep 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ All checks pass
✔️ Only touch the test code. The library code itself already followed this recommendation. 💪🏿

@csouchet csouchet merged commit ce5097e into master Sep 21, 2023
23 checks passed
@csouchet csouchet deleted the 2742-add_unicorn/prefer-logical-operator-over-ternary_rule branch September 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants