Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): add some unicorn rules #2925

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 13, 2023
@github-actions
Copy link

github-actions bot commented Oct 13, 2023

🎊 PR Preview f9cc305 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2925.surge.sh

🕐 Build time: 0.02s

🤖 By surge-preview

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

♻️ PR Preview f9cc305 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csouchet csouchet marked this pull request as ready for review October 13, 2023 08:43
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ All checks pass
✔️ Tested with the surge preview environment: ensure that the Drag&Drop code is still working as we changed the loading logic based on the new eslint rules

@csouchet csouchet merged commit 92483bf into master Oct 13, 2023
27 checks passed
@csouchet csouchet deleted the 2742-add_some_unicorn_rules branch October 13, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants