chore(eslint): add some unicorn rules

.eslintrc.cjs

@@ -49,9 +49,14 @@ module.exports = {
     'unicorn/prefer-logical-operator-over-ternary': 'error',
     'unicorn/consistent-function-scoping': 'error',
     'unicorn/prefer-at': 'error',
+    'unicorn/prefer-blob-reading-methods': 'error',
+    'unicorn/prefer-code-point': 'error',
     'unicorn/prefer-dom-node-append': 'error',
     'unicorn/prefer-dom-node-dataset': 'error',
     'unicorn/prefer-dom-node-remove': 'error',
+    'unicorn/prefer-number-properties': 'error',
+    'unicorn/prefer-set-has': 'error',
+    'unicorn/prefer-set-size': 'error',
     'unicorn/prefer-string-slice': 'error',
     'unicorn/no-negated-condition': 'error',
     'unicorn/no-array-callback-reference': 'error',

dev/ts/component/SvgExporter.ts

@@ -177,7 +177,7 @@ class CanvasForExport extends mxSvgCanvas2D {
       let index = 0;
 
       while ((exp == 0 || length < exp) && index < content.length) {
-        const char = content.charCodeAt(index);
+        const char = content.codePointAt(index);
         if (char == 10 || char == 13) {
           if (length > 0) {
             break;

dev/ts/shared/main.ts

@@ -165,12 +165,15 @@ function collapseBpmnElement(bpmnElementId: string): void {
 }
 
 // callback function for opening | dropping the file to be loaded
-function readAndLoadFile(f: File): void {
-  const reader = new FileReader();
-  reader.addEventListener('load', () => {
-    loadBpmn(reader.result as string);
-  });
-  reader.readAsText(f);
+function readAndLoadFile(file: File): void {
+  file
+    .text()
+    .then(content => {
+      loadBpmn(content);
+    })
+    .catch(error => {
+      throw error;
+    });
 }
 
 // TODO: make File Open Button a self contained component

src/component/mxgraph/config/ShapeConfigurator.ts

@@ -162,6 +162,7 @@ export default class ShapeConfigurator {
       if (!this.antiAlias) {
         // Rounds all numbers in the SVG output to integers
         canvas.format = function (value: string) {
+          // eslint-disable-next-line unicorn/prefer-number-properties -- mxGraph code
           return Math.round(parseFloat(value));
         };
       }

src/component/registry/bpmn-model-registry.ts

@@ -87,12 +87,14 @@ export class BpmnModelRegistry {
 }
 
 function toRenderedModel(bpmnModel: BpmnModel): RenderedModel {
-  const collapsedSubProcessIds: string[] = bpmnModel.flowNodes
-    .filter(shape => {
-      const bpmnElement = shape.bpmnElement;
-      return ShapeUtil.isSubProcess(bpmnElement.kind) && (bpmnElement as ShapeBpmnSubProcess).markers.includes(ShapeBpmnMarkerKind.EXPAND);
-    })
-    .map(shape => shape.bpmnElement.id);
+  const collapsedSubProcessIds = new Set(
+    bpmnModel.flowNodes
+      .filter(shape => {
+        const bpmnElement = shape.bpmnElement;
+        return ShapeUtil.isSubProcess(bpmnElement.kind) && (bpmnElement as ShapeBpmnSubProcess).markers.includes(ShapeBpmnMarkerKind.EXPAND);
+      })
+      .map(shape => shape.bpmnElement.id),
+  );
 
   const subprocesses: Shape[] = [];
   const boundaryEvents: Shape[] = [];
@@ -103,7 +105,7 @@ function toRenderedModel(bpmnModel: BpmnModel): RenderedModel {
       subprocesses.push(shape);
     } else if (ShapeUtil.isBoundaryEvent(kind)) {
       boundaryEvents.push(shape);
-    } else if (!collapsedSubProcessIds.includes(shape.bpmnElement.parentId)) {
+    } else if (!collapsedSubProcessIds.has(shape.bpmnElement.parentId)) {
       otherFlowNodes.push(shape);
     }
   }

src/model/bpmn/internal/shape/utils.ts

@@ -78,7 +78,7 @@ export class ShapeUtil {
   }
 
   static isWithDefaultSequenceFlow(kind: ShapeBpmnElementKind): boolean {
-    return FLOW_NODE_WITH_DEFAULT_SEQUENCE_FLOW_KINDS.includes(kind);
+    return FLOW_NODE_WITH_DEFAULT_SEQUENCE_FLOW_KINDS.has(kind);
   }
 
   /**
@@ -127,12 +127,12 @@ const GATEWAY_KINDS = filterKind('Gateway');
 const TASK_KINDS = filterKind('Task', { ignoreCase: true, notStartingWith: 'global' });
 
 const ACTIVITY_KINDS = [...TASK_KINDS, ShapeBpmnElementKind.CALL_ACTIVITY, ShapeBpmnElementKind.SUB_PROCESS];
-const FLOW_NODE_WITH_DEFAULT_SEQUENCE_FLOW_KINDS = [
+const FLOW_NODE_WITH_DEFAULT_SEQUENCE_FLOW_KINDS = new Set([
   ...ACTIVITY_KINDS,
   ShapeBpmnElementKind.GATEWAY_EXCLUSIVE,
   ShapeBpmnElementKind.GATEWAY_INCLUSIVE,
   ShapeBpmnElementKind.GATEWAY_COMPLEX,
-];
+]);
 
 /**
  * Elements that are effectively used in BPMN diagram as base for eventDefinition i.e all {@link ShapeBpmnEventDefinitionKind} elements except {@link ShapeBpmnEventDefinitionKind.NONE}

test/config/jest.image.ts

@@ -42,7 +42,7 @@ class RetriesCounter {
   // https://github.com/facebook/jest/blob/v27.4.7/packages/jest-circus/src/run.ts#L46
   // eslint-disable-next-line @typescript-eslint/ban-ts-comment -- code adapted from jest-circus
   // @ts-ignore
-  private readonly retryTimes = parseInt(global[Symbol.for('RETRY_TIMES')], 10) || 0;
+  private readonly retryTimes = Number.parseInt(global[Symbol.for('RETRY_TIMES')], 10) || 0;
 
   hasReachMaxRetries(testId: unknown): boolean {
     return !this.retryTimes || this.getExecutionCount(testId) > this.retryTimes;

test/shared/visu/bpmn-page-utils.ts

@@ -26,17 +26,14 @@ import type { ElementHandle, Page } from 'playwright';
 import debugLogger from 'debug';
 
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
+// @ts-ignore js file with commonjs export
 import environmentUtils = require('../environment-utils.cjs');
 
 import { delay } from './test-utils';
 
 import { FitType, type LoadOptions, ZoomType } from '@lib/component/options';
 import { BpmnQuerySelectorsForTests } from '@test/shared/query-selectors';
 
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore js file with commonjs export
-
 const pageCheckLog = debugLogger('bv:test:page-check');
 
 class BpmnPage {