Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating rbacs and logging error #83

Merged
merged 5 commits into from
Jun 21, 2023
+18 −1
Merged

Updating rbacs and logging error #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ce0693
Updating error log output
Fiona-Waters Jun 15, 2023
4a0d07d
updating rbacs
Fiona-Waters Jun 15, 2023
8e45da2
updating to specify required secret
Fiona-Waters Jun 15, 2023
780da77
adding clusterversions
Fiona-Waters Jun 19, 2023
fde1918
updating to use Errorf
Fiona-Waters Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/appwrapper_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (r *AppWrapperReconciler) SetupWithManager(mgr ctrl.Manager) error {
if !useMachineSets {
instascaleOCMSecret, err := kubeClient.CoreV1().Secrets(r.ConfigsNamespace).Get(context.Background(), "instascale-ocm-secret", metav1.GetOptions{})
if err != nil {
klog.Infof("Error getting instascale-ocm-secret from namespace %v", r.ConfigsNamespace)
klog.Errorf("Error getting instascale-ocm-secret from namespace %v - Error : %v", r.ConfigsNamespace, err)
Fiona-Waters marked this conversation as resolved.
Show resolved Hide resolved
}
ocmToken = string(instascaleOCMSecret.Data["token"])
}
Expand Down
17 changes: 17 additions & 0 deletions deployment/instascale-clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,20 @@ rules:
- update
- delete
- patch

- apiGroups:
Fiona-Waters marked this conversation as resolved.
Show resolved Hide resolved
- ""
Fiona-Waters marked this conversation as resolved.
Show resolved Hide resolved
resourceNames:
- instascale-ocm-secret
resources:
- secrets
Fiona-Waters marked this conversation as resolved.
Show resolved Hide resolved
verbs:
- get

- apiGroups:
- config.openshift.io
resources:
- clusterversions
verbs:
- get
- list