Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be reviewed after #14457 is merged.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR fixes a bug in
core/light-client
where theupdate.AttestedHeader.Execution
andupdate.AttestedHeader.ExecutionBranch
were being created based on currentBlock
and notAttestedBlock
.specifically:
AttestedHeader.Execution
andAttestedHeader.ExecutionBranch
.AttestedBlock
input parameter to theCreateNewLightClientUpdate
,CreateNewLightClientOptimisticUpdate
, andCreateNewLightClientFinalityUpdate
in thecore/light-client
.AttestedBlock
input parameter to the same functions above, but inRPC/eth/light-client
.AttestedBlock
from the LC handlers through to thecore
package.BlockToLightClientHeader
function instead of calculating the headers manually incore/light-client
CreateNewLightClientUpdate
function.Which issues(s) does this PR fix?
This PR is needed as part of #12991