Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lc execution header bug #14468

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Inspector-Butters
Copy link
Contributor

This should be reviewed after #14457 is merged.

What type of PR is this?
Bug fix

What does this PR do? Why is it needed?
This PR fixes a bug in core/light-client where the update.AttestedHeader.Execution and update.AttestedHeader.ExecutionBranch were being created based on current Block and not AttestedBlock.

specifically:

  • Adds tests for checking the AttestedHeader.Execution and AttestedHeader.ExecutionBranch.
  • Adds the AttestedBlock input parameter to the CreateNewLightClientUpdate, CreateNewLightClientOptimisticUpdate, and CreateNewLightClientFinalityUpdate in the core/light-client.
  • Adds the AttestedBlock input parameter to the same functions above, but in RPC/eth/light-client.
  • Passes the AttestedBlock from the LC handlers through to the core package.
  • Defines and uses the BlockToLightClientHeader function instead of calculating the headers manually in core/light-client
  • And generally applies the consensus specs to the CreateNewLightClientUpdate function.

Which issues(s) does this PR fix?
This PR is needed as part of #12991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant