Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing multiple images upload #526

Closed
wants to merge 5 commits into from

Conversation

alaxalves
Copy link
Member

@alaxalves alaxalves commented Apr 11, 2019

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@alaxalves alaxalves changed the title Restricting file upload only to images Allowing multiple images upload Apr 11, 2019
Copy link
Contributor

@divyabaid16 divyabaid16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grvsachdeva
Copy link
Member

Hey @alaxalves, multiple images are getting uploaded now but if I upload 3 images, then only one is properly loaded to Images tab and other 2 shows uploading with progress bar.

Like:
multi_image_upload

@jywarren
Copy link
Member

Any updates here, folks? thanks for providing co-reviews! 🎉

@kaustubh-nair
Copy link
Member

Any updates here @alaxalves ?

@alaxalves alaxalves closed this Dec 17, 2019
@alaxalves alaxalves deleted the issue338-image-upload branch December 17, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants