refactor the system ldap role #5511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayiwa
force-pushed
the
i4938_sftp_jammy
branch
8 times, most recently
from
209c225
to
cfb1889
Compare
kayiwa
force-pushed
the
i4938_sftp_jammy
branch
2 times, most recently
from
938eb4c
to
910e1b9
Compare
acozine
reviewed
Nov 8, 2024
kayiwa
force-pushed
the
i4938_sftp_jammy
branch
7 times, most recently
from
a5a6940
to
037476c
Compare
acozine
reviewed
Nov 11, 2024
acozine
reviewed
Nov 11, 2024
acozine
reviewed
Nov 11, 2024
acozine
reviewed
Nov 11, 2024
acozine
reviewed
Nov 11, 2024
| changed_when: false | ||
| when: running_on_server | ||
|
|
||
| - name: Sssd_ad | debug realm list output |
There was a problem hiding this comment.
Let's change this so it stops the playbook if the output is not correct at this stage.
There was a problem hiding this comment.
only way to know what this output is will make this PR larger by incorporating this. https://github.com/pulibrary/princeton_ansible/tree/i4938_sftp_role
acozine
reviewed
Nov 11, 2024
| register: ad_login_result | ||
| when: running_on_server | ||
|
|
||
| - name: Sssd_ad | debug AD login result |
There was a problem hiding this comment.
Make this fail if the output is not correct/complete.
There was a problem hiding this comment.
Same here. I don't know what the output would be https://github.com/pulibrary/princeton_ansible/tree/i4938_sftp_role
acozine
reviewed
Nov 11, 2024
we will create a system ldap role which can be used to bind vms to active directory and sftp role and/or playbook can incorporate this role
our Active Directory bind user goes to group_vars/all because it will be used by any VM that needs to bind to Active Directory
Co-authored-by: Alicia Cozine <[email protected]>
kayiwa
force-pushed
the
i4938_sftp_jammy
branch
from
037476c
to
a76b0dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we will create a system ldap role which can be used to bind vms to active directory
and sftp role and/or playbook can incorporate this role
This PR decouples system ldap from sftp. If it goes in it means any vm that needs to bind to active directory can use it. We've had an example of this need with the RDSS mflux vms. Our Active Directory binding is currently broken so this can be merged to main. A follow up PR for lib-sftp will be coming.
Partially addresses #4938