Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulation mismatch between VCS and QuestaSim #81

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

Xeratec
Copy link
Collaborator

@Xeratec Xeratec commented Apr 17, 2023

During simulations with a custom GitLab branch, I experienced simulation mismatches between QuestaSim and VCS.
Strangely, the snitch_addr_demux module did work with NumRules larger than one. However, with NumRules equal to one, the slave_select signal was not correctly assigned (as shown in the figures below).

Additionally, this PR makes sure that VCS uses the custom compiler specified via the CC and CCX environment variables. This modification was required on my IIS workstation and adds additional flexibility.

Changelog

Changed

  • Use custom compiler for VCS specified with CC and CCX environment variable

Fixed

  • Fix type issue in snitch_addr_demu

Checklist

  • Automated tests pass
  • Check modifications with Synopsys SpyGlass
  • Changelog updated
  • Code style guideline is observed

Images

Correct Behavior in QuestaSim
Questa_Address-Select_01
Incorrect Behavior in QuestaSim
VCS_Address-Select_01

Origin of the Mismatch
VCS_Address-Select_02
VCS_Address-Select_03

Copy link
Member

@SamuelRiedel SamuelRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

@SamuelRiedel SamuelRiedel merged commit 2306bce into pulp-platform:main Jul 20, 2023
31 checks passed
@Xeratec Xeratec deleted the wiesep/pr/fix_vcs branch July 26, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants