Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Fix failing program test #4157

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Fix failing program test #4157

merged 3 commits into from
Apr 9, 2024

Conversation

cnunciato
Copy link
Contributor

@cnunciato cnunciato commented Apr 9, 2024

17 is a valid version, but we run 11 in CI (as this is the earliest supported version).

Fixes pulumi/docs#11464.

@cnunciato cnunciato requested a review from a team April 9, 2024 21:48
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 0b38296 is ready! 🎉

http://pulumi-hugo-origin-pr-4157-0b382964.s3-website.us-west-2.amazonaws.com.

@cnunciato
Copy link
Contributor Author

Oh, looks like this will still fail because the program itself contains features that don't exist in Java 11:

[ERROR] COMPILATION ERROR : 
[ERROR] /Users/cnunciato/Projects/pulumi/pulumi-hugo/themes/default/static/programs/aws-s3-bucket-resources-java/src/main/java/myproject/App.java:[63,30] text blocks are not supported in -source 11

I'll make a tweak and push up a fix for that as well.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit f8d58f9 is ready! 🎉

http://pulumi-hugo-origin-pr-4157-f8d58f9d.s3-website.us-west-2.amazonaws.com.

@cnunciato
Copy link
Contributor Author

Looks like all of these examples also fail to deploy because the policy needs a dependency on the public-access block and ownership controls:

     Type                               Name                              Status                       Info
 +   pulumi:pulumi:Stack                aws-s3-bucket-resources-java-dev  **creating failed (7s)**     1 error
 +   ├─ aws:s3:Bucket                   my-bucket                         created (2s)                 
 +   ├─ aws:s3:BucketPolicy             my-bucket-policy                  **creating failed**          1 error
 +   ├─ aws:s3:BucketMetric             my-bucket-metric                  created (1s)                 
 +   ├─ aws:s3:BucketPublicAccessBlock  public-access-block               created (1s)                 
 +   ├─ aws:s3:BucketOwnershipControls  ownership-controls                created (1s)                 
 +   └─ aws:s3:BucketNotification       my-bucket-notification            created (2s)                 

Diagnostics:
  pulumi:pulumi:Stack (aws-s3-bucket-resources-java-dev):
    error: update failed

  aws:s3:BucketPolicy (my-bucket-policy):
    error: 1 error occurred:
        * putting S3 Bucket (my-bucket-4cf518e) Policy: operation error S3: PutBucketPolicy, https response error StatusCode: 403, RequestID: 60G5RPPK6KGYE6T4, HostID: U14S6Nxcff9ggGN07ZYHkR5pQ0Vi9cp3oGIjfbGLsTqT4Ayyhw1gSgQuQ1uKLAH0vRn0XBYMxZg=, api error AccessDenied: Access Denied

I'll add something for these as well.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit f8403e8 is ready! 🎉

http://pulumi-hugo-origin-pr-4157-f8403e8f.s3-website.us-west-2.amazonaws.com.

@cnunciato cnunciato force-pushed the cnunciato/fix-example-tests branch from f8403e8 to c5bdb1f Compare April 9, 2024 23:03
@pulumi-bot
Copy link
Collaborator

Your site preview for commit c5bdb1f is ready! 🎉

http://pulumi-hugo-origin-pr-4157-c5bdb1f4.s3-website.us-west-2.amazonaws.com.

@cnunciato cnunciato merged commit 7912209 into master Apr 9, 2024
2 checks passed
@cnunciato cnunciato deleted the cnunciato/fix-example-tests branch April 9, 2024 23:47
cnunciato added a commit that referenced this pull request Apr 10, 2024
* Fix failing program test

* Make the Java example 'work'

* Add necessary dependencies
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: Scheduled Jobs: Run Tests
3 participants