Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SDKv2 set detailed diff tests to correct files #2741

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 12, 2024

This PR deletes some of the tests which are now made redundant by equivalent cross-tests and moves the tests for unknowns sets to detailed_diff_unknown_test.go

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Dec 12, 2024

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.61%. Comparing base (0afd418) to head (b4c0769).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2741   +/-   ##
=======================================
  Coverage   68.60%   68.61%           
=======================================
  Files         322      322           
  Lines       41223    41223           
=======================================
+ Hits        28281    28284    +3     
+ Misses      11347    11345    -2     
+ Partials     1595     1594    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 4a4c0ed to a866f4b Compare December 12, 2024 15:31
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 7c5f7c4 to d8b1526 Compare December 13, 2024 16:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from a866f4b to e4e5bb7 Compare December 13, 2024 16:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from d8b1526 to bd80587 Compare December 13, 2024 17:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from e4e5bb7 to 9aa9385 Compare December 13, 2024 17:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from bd80587 to 8afffe0 Compare December 16, 2024 11:38
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 9aa9385 to 7674e1e Compare December 16, 2024 11:38
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 8afffe0 to 8f2b3d6 Compare December 16, 2024 11:39
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 7674e1e to 216e24d Compare December 16, 2024 11:39
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 216e24d to 8be38a7 Compare December 16, 2024 11:41
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 8f2b3d6 to 23ca148 Compare December 16, 2024 12:00
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 8be38a7 to d64775c Compare December 16, 2024 12:00
@t0yv0
Copy link
Member

t0yv0 commented Dec 16, 2024

Waiting on antecedent PR being marked ready then can review!

@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 23ca148 to 983e8df Compare December 16, 2024 15:50
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from d64775c to 605563c Compare December 16, 2024 15:50
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 1310b4d to 3504da5 Compare December 17, 2024 09:49
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 9883d98 to 455e2af Compare December 17, 2024 09:49
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 3504da5 to c99f64d Compare December 17, 2024 09:55
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 455e2af to 00569e8 Compare December 17, 2024 09:55
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from c99f64d to 4c3deba Compare December 17, 2024 15:09
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 00569e8 to 2b42a74 Compare December 17, 2024 15:10
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 2b42a74 to a2644af Compare December 17, 2024 15:30
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from fed65d6 to 8e6731f Compare December 17, 2024 19:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from a2644af to fd71cbe Compare December 17, 2024 19:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 8e6731f to 6e6a723 Compare December 17, 2024 19:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from fd71cbe to 16dbc86 Compare December 17, 2024 19:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from 6e6a723 to fff242e Compare December 18, 2024 10:07
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 16dbc86 to 83dba22 Compare December 18, 2024 10:07
@VenelinMartinov VenelinMartinov force-pushed the vvm/sdkv2_detailed_diff_computed_in_sets branch from fff242e to eae4813 Compare December 18, 2024 10:14
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch 2 times, most recently from 282ac96 to 34568a1 Compare December 18, 2024 11:46
Base automatically changed from vvm/sdkv2_detailed_diff_computed_in_sets to master December 18, 2024 14:15
@VenelinMartinov VenelinMartinov force-pushed the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch from 34568a1 to b4c0769 Compare December 18, 2024 14:16
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) December 18, 2024 14:16
@VenelinMartinov VenelinMartinov merged commit 19692d1 into master Dec 18, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/move_sdkv2_set_detailed_diff_tests_to_correct_files branch December 18, 2024 15:18
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.99.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants