-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SDKv2 set detailed diff tests to correct files #2741
Refactor SDKv2 set detailed diff tests to correct files #2741
Conversation
This change is part of the following stack: Change managed by git-spice. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2741 +/- ##
=======================================
Coverage 68.60% 68.61%
=======================================
Files 322 322
Lines 41223 41223
=======================================
+ Hits 28281 28284 +3
+ Misses 11347 11345 -2
+ Partials 1595 1594 -1 ☔ View full report in Codecov by Sentry. |
4a4c0ed
to
a866f4b
Compare
7c5f7c4
to
d8b1526
Compare
a866f4b
to
e4e5bb7
Compare
d8b1526
to
bd80587
Compare
e4e5bb7
to
9aa9385
Compare
bd80587
to
8afffe0
Compare
9aa9385
to
7674e1e
Compare
8afffe0
to
8f2b3d6
Compare
7674e1e
to
216e24d
Compare
216e24d
to
8be38a7
Compare
8f2b3d6
to
23ca148
Compare
8be38a7
to
d64775c
Compare
Waiting on antecedent PR being marked ready then can review! |
23ca148
to
983e8df
Compare
d64775c
to
605563c
Compare
1310b4d
to
3504da5
Compare
9883d98
to
455e2af
Compare
3504da5
to
c99f64d
Compare
455e2af
to
00569e8
Compare
c99f64d
to
4c3deba
Compare
00569e8
to
2b42a74
Compare
2b42a74
to
a2644af
Compare
fed65d6
to
8e6731f
Compare
a2644af
to
fd71cbe
Compare
8e6731f
to
6e6a723
Compare
fd71cbe
to
16dbc86
Compare
6e6a723
to
fff242e
Compare
16dbc86
to
83dba22
Compare
fff242e
to
eae4813
Compare
282ac96
to
34568a1
Compare
34568a1
to
b4c0769
Compare
This PR has been shipped in release v3.99.0. |
This PR deletes some of the tests which are now made redundant by equivalent cross-tests and moves the tests for unknowns sets to
detailed_diff_unknown_test.go