-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fallback for detailed diff replace decisions to ensure detailed diff is presentation-only #2747
Add a fallback for detailed diff replace decisions to ensure detailed diff is presentation-only #2747
Conversation
This change is part of the following stack: Change managed by git-spice. |
36cecf5
to
e76e9a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## vvm/pf_tests_disable_accurate_previews #2747 +/- ##
=======================================================================
Coverage 68.83% 68.84%
=======================================================================
Files 302 302
Lines 38736 38775 +39
=======================================================================
+ Hits 26663 26693 +30
- Misses 10562 10569 +7
- Partials 1511 1513 +2 ☔ View full report in Codecov by Sentry. |
e76e9a7
to
619c4b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple optional style nits, but it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems very important. Can you add a quick note on flagging, does it roll out right away or it's flagged with accurate previews? Thanks.
619c4b5
to
c83b590
Compare
9156d7f
to
4a091b8
Compare
4a091b8
to
8313f97
Compare
8313f97
to
f3e38a9
Compare
1a62de2
into
vvm/pf_tests_disable_accurate_previews
… diff is presentation-only (#2757) This change adds a fallback for the detailed diff replace decision. This ensures that the detailed diff is presentation only. If we fail to identify the reason for a replace in the detailed diff calculation we mark it against `__meta`, similar to what we did before: https://github.com/pulumi/pulumi-terraform-bridge/blob/a952164c556a86f46dac2ac34e915143cfd7abd8/pkg/tfbridge/provider.go#L1262 If we incorrectly identify a non-existent replace we demote it to an update/create/delete. This is flagged behind the Accurate Previews flag. I've stood up #2747 again as it got accidentally merged into another branch. fixes #2674 fixes #2726
This change adds a fallback for the detailed diff replace decision. This ensures that the detailed diff is presentation only.
If we fail to identify the reason for a replace in the detailed diff calculation we mark it against
__meta
, similar to what we did before:pulumi-terraform-bridge/pkg/tfbridge/provider.go
Line 1262 in a952164
If we incorrectly identify a non-existent replace we demote it to an update/create/delete.
This is flagged behind the Accurate Previews flag.
fixes #2674
fixes #2726