Default Provider fails to apply if it's defined below its resource

[mikhailshilkov]

What happened?

I assume the order of YAML resources should not matter. However, this program works:

name: aws-yaml
runtime: yaml
resources:
  provider:
    defaultProvider: true
    type: pulumi:providers:aws
    properties:
      region: us-west-2
  alb:
    type: aws:alb:LoadBalancer
    properties:
      tags: 
        Name: test-lb
      name: testing
      subnets: 
        - subnet-eacf3697
        - subnet-939b18f8

while the following one fails

name: aws-yaml
runtime: yaml
resources:
  alb:
    type: aws:alb:LoadBalancer
    properties:
      tags: 
        Name: test-lb
      name: testing
      subnets: 
        - subnet-eacf3697
        - subnet-939b18f8
  provider:
    defaultProvider: true
    type: pulumi:providers:aws
    properties:
      region: us-west-2

with

    error: resource or variable named "provider" could not be found
    error: Error registering resource [alb]: no diagnostics
    error: Error registering resource [provider]: no diagnostics

Example

see above

Output of pulumi about

CLI          
Version      3.126.0
Go Version   go1.22.5
Go Compiler  gc

Plugins
KIND      NAME  VERSION
resource  aws   unknown
language  yaml  unknown

Host     
OS       darwin
Version  14.5
Arch     arm64

This project is written in yaml

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[brandonpollack23]

Ok after some digging it seems the topological sort is not aware of the dependency of alb on the aws provider here. Looking into how to pivot on that information if its there and if it isn't figuring out how to add it (perhaps this is an aws provider specific issue but I doubt it)

[brandonpollack23]

More progress: if you explicitly set the provider in the config section it works out. the topological sort doesn't work because it doesn't detect "default provider" I bet I could add a special case for that in topological sort to always put that first so any other resources that expect it will work

[justinvp]

Fixed by #652