Fix topological sort to take into account defaultProvider. #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpollack23
changed the title
brandonpollack23
force-pushed
the
bpollack/default_provider_sorting_604
branch
from
74643ed
to
2266d11
Compare
brandonpollack23
force-pushed
the
bpollack/default_provider_sorting_604
branch
2 times, most recently
from
937b4f1
to
6f23208
Compare
Copy the original description to the PR description. Put comments like that in comments, it doesn't need to merge to git history when we merge this. |
The topological sort will not sort default providers first as is, so this adds in a check to detect it and not allow implicit providers to be complete until the default provider is declared. Bug: #604 Remote-Ref: brandonpollack23/f91181f4
Also added a test to test topological sort works correctly.
Bug: #643
Remote-Ref: brandonpollack23/e8219876
brandonpollack23
force-pushed
the
bpollack/default_provider_sorting_604
branch
from
6f23208
to
606229a
Compare
Frassle
reviewed
Sep 27, 2024
Frassle
approved these changes
Sep 30, 2024
|
Does this fix #604? FYI, for future reference, if you include |
|
This PR has been shipped in release v1.11.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topological sort will not sort default providers first as is, so
this adds in a check to detect it and not allow implicit providers to be
complete until the default provider is declared.
Handle multiple default providers for different packages.
Also added a test to test topological sort works correctly.