Don't error on eventual IDs #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, this program errors:
```yaml
name: dev-yaml
runtime: yaml
resources:
b1:
type: aws:s3:Bucket
b2:
type: aws:s3:Bucket
get:
id: ${b1.id}
```
```console
$ pulumi preview
Previewing update (dev)
View in Browser (Ctrl+O): https://app.pulumi.com/pulumi/dev-yaml/dev/previews/0e23b0b3-33f3-4a5d-abf9-15fb7fb9f23e
Loading policy packs...
Type Name Plan Info
+ pulumi:pulumi:Stack dev-yaml-dev create 2 errors
+ └─ aws:s3:Bucket b1 create
Policies:
⚠️ [email protected]
- [advisory] s3-bucket-replication-enabled (aws:s3/bucket:Bucket: b1)
Encourages use of cross-region replication for S3 buckets.
S3 buckets should have cross-region replication.
Diagnostics:
pulumi:pulumi:Stack (dev-yaml-dev):
error: ${b1.id} must be a string, instead got type pulumi.StringOutput
on Pulumi.yaml line 9:
9: id: ${b1.id}
This indicates a bug in the Pulumi YAML type checker. Please open an issue at https://github.com/pulumi/pulumi-yaml/issues/new/choose
error: Error registering resource [b2]: no diagnostics
```
This PR addresses the problem.
lunaris
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this program errors:
This PR addresses the problem.