Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error on eventual IDs #591

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Don't error on eventual IDs #591

merged 2 commits into from
Jun 21, 2024

Commits on Jun 14, 2024

  1. Don't error on eventual IDs

    Right now, this program errors:
    
    ```yaml
    name: dev-yaml
    runtime: yaml
    resources:
      b1:
        type: aws:s3:Bucket
      b2:
        type: aws:s3:Bucket
        get:
          id: ${b1.id}
    ```
    
    ```console
    $ pulumi preview
    Previewing update (dev)
    
    View in Browser (Ctrl+O): https://app.pulumi.com/pulumi/dev-yaml/dev/previews/0e23b0b3-33f3-4a5d-abf9-15fb7fb9f23e
    
    Loading policy packs...
    
         Type                 Name          Plan       Info
     +   pulumi:pulumi:Stack  dev-yaml-dev  create     2 errors
     +   └─ aws:s3:Bucket     b1            create
    
    Policies:
        ⚠️ [email protected]
            - [advisory]  s3-bucket-replication-enabled  (aws:s3/bucket:Bucket: b1)
              Encourages use of cross-region replication for S3 buckets.
              S3 buckets should have cross-region replication.
    
    Diagnostics:
      pulumi:pulumi:Stack (dev-yaml-dev):
        error: ${b1.id} must be a string, instead got type pulumi.StringOutput
    
          on Pulumi.yaml line 9:
           9:       id: ${b1.id}
    
        This indicates a bug in the Pulumi YAML type checker. Please open an issue at https://github.com/pulumi/pulumi-yaml/issues/new/choose
        error: Error registering resource [b2]: no diagnostics
    
    ```
    
    This PR addresses the problem.
    iwahbe committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ba82fb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Add an integration test

    iwahbe committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    868274a View commit details
    Browse the repository at this point in the history