DOM: support onClose event in dialog element

[Hi-Angel]

See: https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/close_event

[pete-murphy]

Hi, thanks for the PR! The Generated module is output from this: https://github.com/purescript-react/purescript-react-basic-dom/blob/main/codegen/consts.js. Could you move this change to that file instead and run the codegen script?

[Hi-Angel]

Hi, thanks for the PR! The Generated module is output from this: https://github.com/purescript-react/purescript-react-basic-dom/blob/main/codegen/consts.js. Could you move this change to that file instead and run the codegen script?

Thank you, sure! But how do I regenerate the "Generated.pus" file afterwards?

In fact, I've seen that the file is generated, but I waited for someone to suggest how to make the proper change, because the header of the file has no mention how would one generate it 😅

[pete-murphy]

Looks like you should be able to do

cd codegen
npm install
node index.js

[Hi-Angel]

@pete-murphy thank you, done!

I also made a commit that adds an explanation to the header about how to regenerate files, so in the future hopefully contributions from new users will be simpler 😊

Please review

[pete-murphy]

Thanks again! Released as part of v7.0.0 (which includes a breaking change to defaultChecked type: https://github.com/purescript-react/purescript-react-basic-dom/releases/tag/v7.0.0)

Updating the registry here: purescript/registry#501

[Hi-Angel]

@pete-murphy oh, thank you! But what do you think about this suggestion? Would be cool to have it included as well 😊