Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM: support onClose event in dialog element #55

Merged
merged 2 commits into from
Nov 8, 2024
Merged

DOM: support onClose event in dialog element #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee08c7
Support `onClose` event in `dialog` element
Hi-Angel Nov 8, 2024
19b0082
Add explanation on how to modify the generated files
Hi-Angel Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codegen/consts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ module.exports.types = {
"onCanPlayThrough": "EventHandler",
"onChange": "EventHandler",
"onClick": "EventHandler",
"onClose": "EventHandler",
"onCompositionEnd": "EventHandler",
"onCompositionStart": "EventHandler",
"onCompositionUpdate": "EventHandler",
Expand Down
19 changes: 9 additions & 10 deletions codegen/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,15 @@ const htmlGenFile = "../src/React/Basic/DOM/Generated.purs";
const htmlSimplifiedGenFile = "../src/React/Basic/DOM/Simplified/Generated.purs";
const svgGenFile = "../src/React/Basic/DOM/SVG.purs";

const htmlHeader = `-- | ----------------------------------------
const warningHeader = `-- | ------------------------------------------------------------
-- | THIS FILE IS GENERATED -- DO NOT EDIT IT
-- | ----------------------------------------
-- | Instead edit files under 'codegen/' dir and regenerate with:
-- | npm install
-- | node ./index.js
-- | ------------------------------------------------------------
`;

const htmlHeader = `${warningHeader}
module React.Basic.DOM.Generated where

import Data.Nullable (Nullable)
Expand All @@ -23,10 +28,7 @@ import Web.DOM (Node)

`;

const simplifiedHtmlHeader = `-- | ----------------------------------------
-- | THIS FILE IS GENERATED -- DO NOT EDIT IT
-- | ----------------------------------------

const simplifiedHtmlHeader = `${warningHeader}
module React.Basic.DOM.Simplified.Generated where

import Data.Nullable (Nullable)
Expand Down Expand Up @@ -55,10 +57,7 @@ const propType = (e, p) => {
}
}

const svgHeader = `-- | ----------------------------------------
-- | THIS FILE IS GENERATED -- DO NOT EDIT IT
-- | ----------------------------------------

const svgHeader = `${warningHeader}
module React.Basic.DOM.SVG where

import Data.Nullable (Nullable)
Expand Down
1 change: 1 addition & 0 deletions codegen/react-html-attributes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@
"title"
],
"dialog": [
"onClose",
"open"
],
"embed": [
Expand Down
8 changes: 6 additions & 2 deletions src/React/Basic/DOM/Generated.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
-- | ----------------------------------------
-- | ------------------------------------------------------------
-- | THIS FILE IS GENERATED -- DO NOT EDIT IT
-- | ----------------------------------------
-- | Instead edit files under 'codegen/' dir and regenerate with:
-- | npm install
-- | node ./index.js
-- | ------------------------------------------------------------

module React.Basic.DOM.Generated where

Expand Down Expand Up @@ -4310,6 +4313,7 @@ type Props_dialog =
, onAnimationStart :: EventHandler
, onBlur :: EventHandler
, onClick :: EventHandler
, onClose :: EventHandler
, onCompositionEnd :: EventHandler
, onCompositionStart :: EventHandler
, onCompositionUpdate :: EventHandler
Expand Down
7 changes: 5 additions & 2 deletions src/React/Basic/DOM/SVG.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
-- | ----------------------------------------
-- | ------------------------------------------------------------
-- | THIS FILE IS GENERATED -- DO NOT EDIT IT
-- | ----------------------------------------
-- | Instead edit files under 'codegen/' dir and regenerate with:
-- | npm install
-- | node ./index.js
-- | ------------------------------------------------------------

module React.Basic.DOM.SVG where

Expand Down
8 changes: 6 additions & 2 deletions src/React/Basic/DOM/Simplified/Generated.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
-- | ----------------------------------------
-- | ------------------------------------------------------------
-- | THIS FILE IS GENERATED -- DO NOT EDIT IT
-- | ----------------------------------------
-- | Instead edit files under 'codegen/' dir and regenerate with:
-- | npm install
-- | node ./index.js
-- | ------------------------------------------------------------

module React.Basic.DOM.Simplified.Generated where

Expand Down Expand Up @@ -3884,6 +3887,7 @@ type Props_dialog =
, onAnimationStart :: EventHandler
, onBlur :: EventHandler
, onClick :: EventHandler
, onClose :: EventHandler
, onCompositionEnd :: EventHandler
, onCompositionStart :: EventHandler
, onCompositionUpdate :: EventHandler
Expand Down
Loading