Update to v0.15.4 #468
Update to v0.15.4 #468
Conversation
- Removes badges since this is unmaintained, doesn't work with 9.2.3 and there is no alternative
|
@purefunctor could you check if my updates in |
config/routes
Outdated
| @@ -10,7 +10,6 @@ | |||
| /packages/#PathPackageName/#PathVersion/docs PackageVersionDocsR GET | |||
| /packages/#PathPackageName/#PathVersion/docs/#Text PackageVersionModuleDocsR GET | |||
| !/packages/#PathPackageName/docs/#Text PackageModuleDocsR GET | |||
| !/packages/#PathPackageName/badge PackageBadgeR GET | |||
There was a problem hiding this comment.
I'm not actually sure we can drop badge support altogether. If I recall correctly, most of the packages within core make use of this for their READMEs. If we need to fork barrier to work with 9.2.3 then I could probably pick up that task.
There was a problem hiding this comment.
Looks like it just needs its upper bound updated: purefunctor/barrier@79e8fc3
There was a problem hiding this comment.
cool, yeah that sounds doable.
There was a problem hiding this comment.
Looks like Phil did the same thing a few years ago: philopon/barrier#4
There was a problem hiding this comment.
ok I guess we can try open a PR and see if we get a response
There was a problem hiding this comment.
I added it to extra-deps, but I can't get it to build.
There was a problem hiding this comment.
Ok, I think I need to relax the bounds for bytestring in barrier: purefunctor/barrier@db5e27c
There was a problem hiding this comment.
Thanks to @i-am-the-slime I got the stack build working as well.
There was a problem hiding this comment.
@purefunctor if you move it to purescript-contrib I can update the dependencies. Apart fromt his I think it is good to go now
Co-authored-by: Justin Garcia <[email protected]>
src/Handler/Caching.hs
Outdated
| @@ -102,7 +102,6 @@ clearCache pkgName version = do | |||
| eachRouteDir | |||
| [ PackageVersionR pkgName' (PathVersion version) | |||
| , PackageAvailableVersionsR pkgName' | |||
| , PackageBadgeR pkgName' | |||
There was a problem hiding this comment.
Should this be readded?
stack.yaml
Outdated
| system-ghc: true | ||
| compiler: ghc-9.2.3 | ||
| compiler-check: match-exact |
There was a problem hiding this comment.
I'm not familiar with stack.yaml in general. Why are these needed?
There was a problem hiding this comment.
oh yes that accidenily slipped into the commit
|
Woops, CI breaks because I force pushed on my |
|
Ok updated it to this commit |
|
@JordanMartinez can you re-run the pipeline? |
Restarted. Sorry about the delay. |
|
Next try :D |
|
Ok I think now it should be good :D |
|
Once this is good, it would be great to get #469 approved & merged as well and then do a deployment |
|
@garyb Assuming this builds, can I get another approval here? I'm not sure if @purefunctor's approval (if it was given) would count due to not being a core team member. If I'm wrong, feel free to correct me. |
How about promoting @purefunctor to the core team so you can be sure about it? :) |
|
Thanks all! |
Update pursuit to 0.15.4.
Apparently
barrier, the library to render badges, is hopelessly outdated and doesn't work with GHC 9.2.3. I haven't found any replacement for rendering badges. Not sure if anyone wants to fork, update and maintain this library? Otherwise I would propose to drop badge support.