Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native nox for tests (not @cs01 fork of nox) #512

Merged
merged 14 commits into from
Oct 3, 2020

Conversation

itsayellow
Copy link
Contributor

  • I have added an entry to docs/changelog.md

Summary of changes

Due presumably to updates in virtualenv, and possibly nox, we can now use regular nox for our tests and don't need to use the special fork of nox.

Closes #508

This seems to work fine. However, in the future if we ever notice something that requires venv to be used in nox tests, we can add venv_backend="venv" as an argument to @nox.session() before def tests() in noxfile.py.

Test plan

Tested by running

# command(s) to exercise these changes

@itsayellow itsayellow requested a review from a team October 2, 2020 04:15
Copy link
Member

@cs01 cs01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you. I'm so glad I can delete my branch now.

@itsayellow itsayellow merged commit 807f26f into pypa:master Oct 3, 2020
@itsayellow itsayellow deleted the native-nox branch October 3, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we use regular nox (and not the special native-venv nox fork?)
2 participants