Use native nox for tests (not @cs01 fork of nox)

.github/workflows/on-push.yml

@@ -81,13 +81,16 @@ jobs:
     # Build regex wheel into pip cache, so future pipx installs don't compile.
     # This avoids future compile errors in nox tests because of missing
     #   header files.
+    # Inside a pytest session, tests/conftest.py removes all existing paths from
+    #   the system PATH, which can cause C compilation to fail.  So here we
+    #   pre-build some packages' wheels outside of pytest.
     - name: Install wheel and build wheel for regex to pip cache
       if: ${{ runner.os == 'macOS' }}
       run: |
         python -m pip install wheel
         python -m pip install regex
-    - name: Install native-venv version of nox
-      run: pip install --use-feature=2020-resolver git+https://github.com/cs01/nox.git@5ea70723e9e6#egg=nox
+    - name: Install nox
+      run: pip install nox
     - name: Execute Tests
       run: |
         nox --non-interactive --session tests-${{ matrix.python-version }}

docs/contributing.md

@@ -16,12 +16,9 @@ pipx uses an automation tool called [nox](https://pypi.org/project/nox/) for dev
 
 Install nox for pipx development:
 ```
-python -m pip install --user git+https://github.com/cs01/nox.git@5ea70723e9e6 nox
+python -m pip install --user nox
 ```
 
-!!! note
-    A specific version of nox must be used for pipx development until [nox issue 233](https://github.com/theacodes/nox/issues/233) is resolved.
-
 Tests are defined as `nox` sessions. You can see all nox sessions with
 ```
 nox -l
@@ -54,13 +51,13 @@ nox -s tests-3.7
 ```
 
 !!! tip
-    You can running a specific unit test by passing arguments to pytest, the test runner pipx uses:
+    You can run a specific unit test by passing arguments to pytest, the test runner pipx uses:
 
     ```
     nox -s tests-3.8 -- -k EXPRESSION
     ```
 
-    Expression can be a test name, such as
+    `EXPRESSION` can be a test name, such as
 
     ```
     nox -s tests-3.8 -- -k test_uninstall

makefile

@@ -1,15 +1,13 @@
 .PHONY: test docs develop build publish publish_docs lint
 
 develop:
-	pipx run --spec=git+https://github.com/cs01/nox.git@5ea70723e9e6 nox -s develop
+	pipx run nox -s develop
 
 lint:
 	pipx run nox -s lint
 
 test:
-	# TODO use `pipx run nox` when nox supports venv creation (and thus
-	# pipx tests pass)
-	pipx run --spec=git+https://github.com/cs01/nox.git@5ea70723e9e6 nox
+	pipx run nox
 
 publish:
 	pipx run nox -s publish-3.7

noxfile.py

@@ -4,15 +4,6 @@
 
 import nox  # type: ignore
 
-# NOTE: these tests require nox to create virtual environments
-# with venv. nox currently uses virtualenv. pipx
-# uses a fork of nox at https://github.com/cs01/nox
-# on the branch cs01/use-venv
-# To invoke nox for pipx, use:
-# pipx run --spec=git+https://github.com/cs01/nox.git@2ba8984a nox
-# until this is fixed in nox. See
-# https://github.com/theacodes/nox/issues/199
-
 python = ["3.6", "3.7", "3.8"]
 
 if sys.platform == "win32":

tests/conftest.py

@@ -22,4 +22,7 @@ def pipx_temp_env(tmp_path, monkeypatch):
     monkeypatch.setattr(constants, "PIPX_LOCAL_VENVS", home_dir / "venvs")
     monkeypatch.setattr(constants, "PIPX_VENV_CACHEDIR", home_dir / ".cache")
 
+    # TODO: macOS needs /usr/bin in PATH to compile certain packages, but
+    #   applications in /usr/bin cause test_install.py tests to raise warnings
+    #   which make tests fail (e.g. on Github ansible apps exist in /usr/bin)
     monkeypatch.setenv("PATH", str(bin_dir))

tests/helpers.py

@@ -1,16 +1,12 @@
-from shutil import which
 import subprocess
 import sys
+from shutil import which
 from typing import List
 from unittest import mock
 
 from pipx import main
 
 
-def assert_not_in_virtualenv():
-    assert not hasattr(sys, "real_prefix"), "Tests cannot run under virtualenv"
-
-
 def run_pipx_cli(pipx_args: List[str]):
     with mock.patch.object(sys, "argv", ["pipx"] + pipx_args):
         return main.cli()

tests/test_install.py

@@ -5,12 +5,9 @@
 
 import pytest  # type: ignore
 
-from helpers import assert_not_in_virtualenv, run_pipx_cli, which_python
+from helpers import run_pipx_cli, which_python
 from pipx import constants
 
-assert_not_in_virtualenv()
-
-
 PYTHON3_5 = which_python("python3.5")
 
 

tests/test_main.py

@@ -3,11 +3,9 @@
 
 import pytest  # type: ignore
 
-from helpers import assert_not_in_virtualenv, run_pipx_cli
+from helpers import run_pipx_cli
 from pipx import main
 
-assert_not_in_virtualenv()
-
 
 def test_help_text(monkeypatch, capsys):
     mock_exit = mock.Mock(side_effect=ValueError("raised in test to exit early"))

tests/test_pipx_metadata_file.py

@@ -3,13 +3,10 @@
 import pytest  # type: ignore
 
 import pipx.constants
-from helpers import assert_not_in_virtualenv, run_pipx_cli
+from helpers import run_pipx_cli
 from pipx.pipx_metadata_file import PackageInfo, PipxMetadata
 from pipx.util import PipxError
 
-assert_not_in_virtualenv()
-
-
 TEST_PACKAGE1 = PackageInfo(
     package="test_package",
     package_or_url="test_package_url",