Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] gh-115349: Pin theme to fix code snippets #115351

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 12, 2024

python-docs-theme 2023.3.1 was the last release before the dark theme was released in 2023.7.

The minimal fix is to pin to the last light-only version.

Before

image

After

image

@hugovk hugovk added docs Documentation in the Doc dir needs backport to 3.8 labels Feb 12, 2024
@ambv ambv merged commit 3fcea41 into python:3.9 Feb 13, 2024
14 checks passed
@miss-islington-app
Copy link

Thanks @hugovk for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @hugovk and @ambv, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3fcea416f8261790ce700c52c4262ccb668716d6 3.8

ambv pushed a commit to ambv/cpython that referenced this pull request Feb 13, 2024
…-115351)

Pin theme to fix code snippets
(cherry picked from commit 3fcea41)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 13, 2024

GH-115404 is a backport of this pull request to the 3.8 branch.

@hugovk hugovk deleted the 3.9-pin-theme branch February 13, 2024 13:15
ambv added a commit that referenced this pull request Feb 13, 2024
(cherry picked from commit 3fcea41)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants