Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-123714: Update JIT compilation to use LLVM 19 #124093

Closed
wants to merge 13 commits into from

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Sep 14, 2024

This PR updates the JIT to use LLVM 19. My current testing approach does not currently take advantage of any new LLVM features, which we may want to consider.

@savannahostrowski
Copy link
Member Author

savannahostrowski commented Sep 14, 2024

The CI will all fail 🤣 because 19 isn't available anywhere yet. I could have waited to push this up, but this is probably going to be a very iterative process for a bit. Carry on...

@savannahostrowski
Copy link
Member Author

savannahostrowski commented Sep 25, 2024

LLVM 19.1.0 is now available on choco and brew so I'm opting to re-run CI here. Running locally on Windows, Mac and Ubuntu produced no build errors.

It looks like LLVM 19 is still being tested for Fedora 42, so I'll hold off on updating the Devcontainer blurb in the README for now. Depending on the timeline for that, we could also consider dropping the Devcontainer instructions until Fedora catches up (and add them back once 19 comes OOB with Fedora)

@brandtbucher brandtbucher self-assigned this Sep 27, 2024
@picnixz
Copy link
Contributor

picnixz commented Sep 27, 2024

What are the distributions that are actually waited upon in general? is openSUSE Tumbleweed (the rolling-release one) part of it (currently, it's LLVM 18)? openSUSE 15.5/6 support LLVM 19 as an experimental package so it's not really an issue for me I think but I wonder whether we could identify which LLVm 19 features are really needed (out of interest, I'm not maintaining anything on openSUSE).

@savannahostrowski
Copy link
Member Author

savannahostrowski commented Sep 27, 2024

Right now, it seems like folks building with the JIT are covered by the distributions covered in the README. This has been sufficient up until this point, especially since the JIT is experimental.

@brandtbucher and I are also investigating removing the LLVM dependency for folks wanting to build with the JIT. This was discussed at the sprint (Brandt will be posting a summary on Discourse soon to make sure that others have the opportunity to weigh in) but there's also a related issue covering a piece of this - #115869.

@savannahostrowski
Copy link
Member Author

Closing in favour of #125499 to simplify merging PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review build The build process and cross-build topic-JIT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants