-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-125498: Replace ghccc with preserve_none
in JIT builds
#125499
base: main
Are you sure you want to change the base?
Conversation
CI failures seem to be related to #125521 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Should I run benchmarks?
Initial review of these changes below. Also, this should probably have its own blurb.
Once CI passes, yes! Let's run the benchmarks. Thanks for the review! |
Can you merge in main to get this fix in? That way we can benchmark on Windows as well. |
@mdboom Done! |
So it looks like the Python version installed with |
Update as of 10/22: |
preserve_none
in JIT builds #125498